Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31297: Narrowed user preferences values to the available list #1211

Merged
merged 1 commit into from Jan 30, 2020
Merged

EZP-31297: Narrowed user preferences values to the available list #1211

merged 1 commit into from Jan 30, 2020

Conversation

michal-myszka
Copy link
Contributor

@michal-myszka michal-myszka commented Jan 28, 2020 •
edited

Question Answer
Tickets https://jira.ez.no/browse/EZP-31297
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Resolve ticket issue (Symfony bugfix adaptation)

SF bugfix:
symfony/symfony#29500
symfony/symfony#29501

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

EZP-31297 - Narrowed user preferences values to the available list (S…
fbc1254 
…ymfony bugfix adaptation for BaseChoiceLoader)
@michal-myszka michal-myszka self-assigned this Jan 28, 2020
ViniTou
ViniTou approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just fyi, same ChoiceLoaders are used in others bundles.

@michal-myszka
Copy link
Contributor Author

just fyi, same ChoiceLoaders are used in others bundles.

thank you @ViniTou . I've found only in current (admin-ui) and user bundle usages of BaseChoiceLoader (ezplatform enterprise base installation). But everywhere, where choice loader is used previous behaviour shouldn't be desirable (also in Symfony core base callback class (and the others also) \Symfony\Component\Form\ChoiceList\Loader\CallbackChoiceLoader this was fixed)

@tomaszszopinski tomaszszopinski self-assigned this Jan 29, 2020
tomaszszopinski
tomaszszopinski approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform OSS v2.5.8 & eZ Platform EE v2.5.8 with diff.

@lserwatka lserwatka merged commit 57fc9ee into 1.5 Jan 30, 2020
@lserwatka lserwatka deleted the EZP-31297-narrowed-user-preferences-values-to-the-available-list branch January 30, 2020 10:41
@lserwatka
Copy link
Member

Could you merge it up?

@michal-myszka
Copy link
Contributor Author

Merged up to master

This was referenced May 18, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glye glye glye approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@ViniTou ViniTou ViniTou approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@michal-myszka michal-myszka

@tomaszszopinski tomaszszopinski

Labels
Bug QA approved Ready for QA
Milestone
No milestone
6 participants
@michal-myszka @lserwatka @glye @mikadamczyk @ViniTou @tomaszszopinski