clean: remove ConsoleContext
entirely by using buildStart
#414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
ConsoleContext
(and the need for it) by using thebuildStart
hook instead of theoptions
hookinclude
d files missed bytransform
(type-only files) #345 (comment)Details
the only reason that
ConsoleContext
was still used was because theoptions
hook doesn't support certain context functions likethis.error
/this.warn
etcbuildStart
does! so we can just move pretty much everything intobuildStart
insteadrollupOptions
because that value gets hashed and the value inbuildStart
is different, as it is after all plugins'options
hooks have ranConsoleContext
what-so-ever and so can remove it entirely!IContext
, its tests, etcuse
this.error
instead ofthrow
ing errors inparse-tsconfig
as it exists nowoptions
hook, can inbuildStart
rpt2:
prefixes ever missing againparse-tsconfig.spec
to account for this change