test: ensure declarationMap sources are correct
#403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
kind: internal
This was referenced Jul 29, 2022
|
CI failed on an integration test suite timeout, but this PR itself shouldn't have increased the time by more than some milliseconds, so think it makes sense to just re-run CI in this case. |
- since we set a placeholder `outDir` initially, TS sets declaration map sources to that placeholder dir - then, after ec0568b, we remap that to the correct dir that Rollup outputs to - this test checks that the remap happens and is correct
agilgur5
force-pushed
the
test-dec-map-sources
branch
from
100e853
to
0d191a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this is built on top of #386 as thetestDirchanges there are required to have a correctoutDir. As such, I've marked this PR as "Draft" until that PR is merged.Rebased on top and marked as ready for review.
Summary
Add a test for
declarationMapsourcesto make sure they're correct after #221 / #204Details
outDirinitially, TS sets declaration map sources to that placeholder dir