fix(diagnostics): workaround Rollup duplicating error messages #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a workaround for a Rollup bug that causes duplicate error messages
pretty: true
) #103pretty
defaults totrue
in TS 2.9+ #372, which makes this bug much more noticeableDetails
per Duplicate error message (esp. when
pretty: true
) #103 (comment) and my investigation in fix(diagnostics):pretty
defaults totrue
in TS 2.9+ #372, it seems like Rollup has a bug where it duplicates some error messagethis fix adds a workaround for this upstream Rollup bug
Review Notes
This is gonna merge conflict pretty hard with #345 's current code (as these both add the
buildEnd
hook), but I made them both compatible with each other. Will just have to update one or the other when one is mergedFuture Work
I'll make a PR to Rollup proper and link it here as well