Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize paths in get-options-overrides #331

Merged

Commits on May 26, 2022

  1. fix: normalize paths in get-options-overrides

    - the `outDir` was not normalized after the `/placeholder` part was
      added to `cacheRoot`
      - `cacheRoot` could have `\` directory separators on it on Windows,
        which caused some tests to fail on Windows before
      - tests have been normalized now too
    
    - `expandIncludeWithDirs` used `path.join` without normalizing after
      - `path.join` uses the OS's native separators (`posix.join` would do
        POSIX separators only), so when the paths were already normalized
        and then `path.join`ed, this would cause mixed separators on Windows
      - this fixes the current CI failure on Windows in the `createFilter`
        tests (`rootDirs` and `projectReferences`, which use
        `expandIncludeWithDirs`)
        - c.f. https://github.com/ezolenko/rollup-plugin-typescript2/runs/6516149780?check_suite_focus=true
    agilgur5 committed May 26, 2022
    Configuration menu
    Copy the full SHA
    52edab7 View commit details
    Browse the repository at this point in the history