Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @yarn-tool/resolve-package from 1.0.40 to 1.0.47 to remove @types/node transitive peerDep #324

Closed
wants to merge 1 commit into from
Closed

Update @yarn-tool/resolve-package from 1.0.40 to 1.0.47 to remove @types/node transitive peerDep #324

wants to merge 1 commit into from

Conversation

felipecrs
Copy link

@felipecrs felipecrs commented May 11, 2022 •
edited

In order to fix this issue:

bluelovers/ws-iconv#5

This package-lock.json was produced by running:

❯ node --version
v16.15.0
❯ npm --version
8.9.0
❯ npm update @yarn-tool/resolve-package

@agilgur5 agilgur5 changed the title Update @yarn-tool/resolve-package from 1.0.40 to 1.0.47 Update @yarn-tool/resolve-package from 1.0.40 to 1.0.47 to remove @types/node transitive peerDep May 12, 2022
@agilgur5 agilgur5 added the scope: dependencies Issues or PRs about updating a dependency label May 12, 2022
@agilgur5
Copy link
Collaborator

agilgur5 commented May 12, 2022 •
edited

rpt2 doesn't pin a version of this dep, just the major, so you should be able to update this yourself in your own package-lock.json without needing rpt2 to make any changes (that is one of the benefits of not pinning, after all)

@agilgur5 agilgur5 added the solution: not needed This PR makes changes that are redundant or otherwise not needed label May 12, 2022
@felipecrs
Copy link
Author

You are right. Thank you!

@felipecrs felipecrs closed this May 12, 2022
@felipecrs felipecrs deleted the update-dep branch May 12, 2022 13:08
@felipecrs felipecrs mentioned this pull request May 12, 2022
Closed
@agilgur5
Copy link
Collaborator

Just a relevant FYI: I actually removed @yarn-tool/resolve-package as a dep in #326, so once a new version of rpt2 is released, you should be able to upgrade to it to remove the dep (and the transitive @types/node dep from there)

@agilgur5 agilgur5 added the kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs label May 26, 2022
@agilgur5
Copy link
Collaborator

agilgur5 commented Jun 2, 2022

0.32.0 no longer has @yarn-tool/resolve-package as a dep

Repository owner locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
kind: internal Changes only affect the internals, and _not_ the public API or external-facing docs scope: dependencies Issues or PRs about updating a dependency solution: not needed This PR makes changes that are redundant or otherwise not needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felipecrs @agilgur5