-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fingerprint] introduce fingerprint.config.js support #28860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
const supportedConfigKeys: (keyof Config)[] = [ | ||
'concurrentIoLimit', | ||
'hashAlgorithm', | ||
'extraSources', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the value for this key serializable to JSON? (can it be specified)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly, the config is just configurable Options. probably Buffer is not serializable but can use string instead.
would make the implementation simpler first without validator or parser. let's add it later if necessary.
Why
follow up feedback from #28712 that we should add fingerprint config support.
How
introduce
fingerprint.config.js
support to override Options. not all options are supported, becauseignorePaths
we would like to use.fingerprintignore
andplatform
is not supported for sure.the priority is explicit Options > fingerprint.config.js > default Options.
Test Plan
fingerprint.config.js
in a project and see whether the result fingerprint hash would be sha256Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).