-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android][symbols] Support material symbols on android #28845
base: main
Are you sure you want to change the base?
Conversation
The Pull Request introduced fingerprint changes against the base commit: 1a9913d Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-symbols/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "d5aae19d1a83f1863a4560de3c5c05c380d6ad91"
},
{
"type": "dir",
"filePath": "../../packages/expo-symbols/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "caaabfa58f0ce5e3228f30aaa44082e2765d3222"
},
{
"type": "contents",
"id": "expoAutolinkingConfig:android",
"contents": "{\"extraDependencies\":[],\"modules\":[{\"packageName\":\"expo\",\"packageVersion\":\"51.0.6\",\"projects\":[{\"name\":\"expo\",\"sourceDir\":\"../../packages/expo/android\"}],\"modules\":[]},{\"packageName\":\"expo-application\",\"packageVersion\":\"5.9.1\",\"projects\":[{\"name\":\"expo-application\",\"sourceDir\":\"../../packages/expo-application/android\"}],\"modules\":[\"expo.modules.application.ApplicationModule\"]},{\"packageName\":\"expo-asset\",\"packageVersion\":\"10.0.6\",\"projects\":[{\"name\":\"expo-asset\",\"sourceDir\":\"../../packages/expo-asset/android\"}],\"modules\":[\"expo.modules.asset.AssetModule\"]},{\"packageName\":\"expo-av\",\"packageVersion\":\"14.0.4\",\"projects\":[{\"name\":\"expo-av\",\"sourceDir\":\"../../packages/expo-av/android\"}],\"modules\":[\"expo.modules.av.video.VideoViewModule\",\"expo.modules.av.AVModule\"]},{\"packageName\":\"expo-background-fetch\",\"packageVersion\":\"12.0.1\",\"projects\":[{\"name\":\"expo-background-fetch\",\"sourceDir\":\"../../packages/expo-background-fetch/android\"}],\"modules\":[\"expo.modules.backgroundfetch.BackgroundFetchModule\"]},{\"packageName\":\"expo-barcode-scanner\",\"packageVersion\":\"13.0.1\",\"projects\":[{\"name\":\"expo-barcode-scanner\",\"sourceDir\":\"../../packages/expo-barcode-scanner/android\"}],\"modules\":[\"expo.modules.barcodescanner.BarCodeScannerModule\"]},{\"packageName\":\"expo-battery\",\"packageVersion\":\"8.0.1\",\"projects\":[{\"name\":\"expo-battery\",\"sourceDir\":\"../../packages/expo-battery/android\"}],\"modules\":[\"expo.modules.battery.BatteryModule\"]},{\"packageName\":\"expo-blur\",\"packageVersion\":\"13.0.2\",\"projects\":[{\"name\":\"expo-blur\",\"sourceDir\":\"../../packages/expo-blur/android\"}],\"modules\":[\"expo.modules.blur.BlurModule\"]},{\"packageName\":\"expo-brightness\",\"packageVersion\":\"12.0.1\",\"projects\":[{\"name\":\"expo-brightness\",\"sourceDir\":\"../../packages/expo-brightness/android\"}],\"modules\":[\"expo.modules.brightness.BrightnessModule\"]},{\"packageName\":\"expo-calendar\",\"packageVersion\":\"13.0.5\",\"projects\":[{\"name\":\"expo-calendar\",\"sourceDir\":\"../../packages/expo-calendar/android\"}],\"modules\":[\"expo.modules.calendar.CalendarModule\"]},{\"packageName\":\"expo-camera\",\"packageVersion\":\"15.0.8\",\"projects\":[{\"name\":\"expo-camera\",\"sourceDir\":\"../../packages/expo-camera/android\"}],\"modules\":[\"expo.modules.camera.CameraViewModule\",\"expo.modules.camera.legacy.CameraViewLegacyModule\"]},{\"packageName\":\"expo-cellular\",\"packageVersion\":\"6.0.2\",\"projects\":[{\"name\":\"expo-cellular\",\"sourceDir\":\"../../packages/expo-cellular/android\"}],\"modules\":[\"expo.modules.cellular.CellularModule\"]},{\"packageName\":\"expo-clipboard\",\"packageVersion\":\"6.0.3\",\"projects\":[{\"name\":\"expo-clipboard\",\"sourceDir\":\"../../packages/expo-clipboard/android\"}],\"modules\":[\"expo.modules.clipboard.ClipboardModule\"]},{\"packageName\":\"expo-constants\",\"packageVersion\":\"16.0.1\",\"projects\":[{\"name\":\"expo-constants\",\"sourceDir\":\"../../packages/expo-constants/android\"}],\"modules\":[\"expo.modules.constants.ConstantsModule\"]},{\"packageName\":\"expo-contacts\",\"packageVersion\":\"13.0.3\",\"projects\":[{\"name\":\"expo-contacts\",\"sourceDir\":\"../../packages/expo-contacts/android\"}],\"modules\":[\"expo.modules.contacts.ContactsModule\"]},{\"packageName\":\"expo-crypto\",\"packageVersion\":\"13.0.2\",\"projects\":[{\"name\":\"expo-crypto\",\"sourceDir\":\"../../packages/expo-crypto/android\"}],\"modules\":[\"expo.modules.crypto.CryptoModule\"]},{\"packageName\":\"expo-dev-client\",\"packageVersion\":\"4.0.13\",\"projects\":[{\"name\":\"expo-dev-client\",\"sourceDir\":\"../../packages/expo-dev-client/android\"}],\"modules\":[]},{\"packageName\":\"expo-dev-launcher\",\"packageVersion\":\"4.0.14\",\"projects\":[{\"name\":\"expo-dev-launcher\",\"sourceDir\":\"../../packages/expo-dev-launcher/android\"}],\"plugins\":[{\"id\":\"expo-dev-launcher-gradle-plugin\",\"group\":\"expo.modules\",\"sourceDir\":\"../../packages/expo-dev-launcher/expo-dev-launcher-gradle-plugin\"}],\"modules\":[]},{\"packageName\":\"expo-dev-menu\",\"packageVersion\":\"5.0.14\",\"projects\":[{\"name\":\"expo-dev-menu\",\"sourceDir\":\"../../packages/expo-dev-menu/android\"}],\"modules\":[\"expo.modules.devmenu.modules.DevMenuModule\",\"expo.modules.devmenu.modules.DevMenuPreferences\"]},{\"packageName\":\"expo-dev-menu-interface\",\"packageVersion\":\"1.8.3\",\"projects\":[{\"name\":\"expo-dev-menu-interface\",\"sourceDir\":\"../../packages/expo-dev-menu-interface/android\"}],\"modules\":[]},{\"packageName\":\"expo-device\",\"packageVersion\":\"6.0.2\",\"projects\":[{\"name\":\"expo-device\",\"sourceDir\":\"../../packages/expo-device/android\"}],\"modules\":[\"expo.modules.device.DeviceModule\"]},{\"packageName\":\"expo-document-picker\",\"packageVersion\":\"12.0.1\",\"projects\":[{\"name\":\"expo-document-picker\",\"sourceDir\":\"../../packages/expo-document-picker/android\"}],\"modules\":[\"expo.modules.documentpicker.DocumentPickerModule\"]},{\"packageName\":\"expo-eas-client\",\"packageVersion\":\"0.12.0\",\"projects\":[{\"name\":\"expo-eas-client\",\"sourceDir\":\"../../packages/expo-eas-client/android\"}],\"modules\":[\"expo.modules.easclient.EASClientModule\"]},{\"packageName\":\"expo-file-system\",\"packageVersion\":\"17.0.1\",\"projects\":[{\"name\":\"expo-file-system\",\"sourceDir\":\"../../packages/expo-file-system/android\"}],\"modules\":[\"expo.modules.filesystem.FileSystemModule\"]},{\"packageName\":\"expo-font\",\"packageVersion\":\"12.0.5\",\"projects\":[{\"name\":\"expo-font\",\"sourceDir\":\"../../packages/expo-font/android\"}],\"modules\":[\"expo.modules.font.FontLoaderModule\"]},{\"packageName\":\"expo-gl\",\"packageVersion\":\"14.0.2\",\"projects\":[{\"name\":\"expo-gl\",\"sourceDir\":\"../../packages/expo-gl/android\"}],\"modules\":[\"expo.modules.gl.GLViewModule\",\"expo.modules.gl.GLObjectManagerModule\"]},{\"packageName\":\"expo-haptics\",\"packageVersion\":\"13.0.1\",\"projects\":[{\"name\":\"expo-haptics\",\"sourceDir\":\"../../packages/expo-haptics/android\"}],\"modules\":[\"expo.modules.haptics.HapticsModule\"]},{\"packageName\":\"expo-image\",\"packageVersion\":\"1.12.9\",\"projects\":[{\"name\":\"expo-image\",\"sourceDir\":\"../../packages/expo-image/android\"}],\"modules\":[\"expo.modules.image.ExpoImageModule\"]},{\"packageName\":\"expo-image-loader\",\"packageVersion\":\"4.7.0\",\"projects\":[{\"name\":\"expo-image-loader\",\"sourceDir\":\"../../packages/expo-image-loader/android\"}],\"modules\":[]},{\"packageName\":\"expo-image-manipulator\",\"packageVersion\":\"12.0.5\",\"projects\":[{\"name\":\"expo-image-manipulator\",\"sourceDir\":\"../../packages/expo-image-manipulator/android\"}],\"modules\":[\"expo.modules.imagemanipulator.ImageManipulatorModule\"]},{\"packageName\":\"expo-image-picker\",\"packageVersion\":\"15.0.4\",\"projects\":[{\"name\":\"expo-image-picker\",\"sourceDir\":\"../../packages/expo-image-picker/android\"}],\"modules\":[\"expo.modules.imagepicker.ImagePickerModule\"]},{\"packageName\":\"expo-insights\",\"packageVersion\":\"0.7.0\",\"projects\":[{\"name\":\"expo-insights\",\"sourceDir\":\"../../packages/expo-insights/android\"}],\"modules\":[\"expo.modules.insights.ExpoInsightsModule\"]},{\"packageName\":\"expo-intent-launcher\",\"packageVersion\":\"11.0.1\",\"projects\":[{\"name\":\"expo-intent-launcher\",\"sourceDir\":\"../../packages/expo-intent-launcher/android\"}],\"modules\":[\"expo.modules.intentlauncher.IntentLauncherModule\"]},{\"packageName\":\"expo-json-utils\",\"packageVersion\":\"0.13.1\",\"projects\":[{\"name\":\"expo-json-utils\",\"sourceDir\":\"../../packages/expo-json-utils/android\"}],\"modules\":[]},{\"packageName\":\"expo-keep-awake\",\"packageVersion\":\"13.0.1\",\"projects\":[{\"name\":\"expo-keep-awake\",\"sourceDir\":\"../../packages/expo-keep-awake/android\"}],\"modules\":[\"expo.modules.keepawake.KeepAwakeModule\"]},{\"packageName\":\"expo-linear-gradient\",\"packageVersion\":\"13.0.2\",\"projects\":[{\"name\":\"expo-linear-gradient\",\"sourceDir\":\"../../packages/expo-linear-gradient/android\"}],\"modules\":[\"expo.modules.lineargradient.LinearGradientModule\"]},{\"packageName\":\"expo-local-authentication\",\"packageVersion\":\"14.0.1\",\"projects\":[{\"name\":\"expo-local-authentication\",\"sourceDir\":\"../../packages/expo-local-authentication/android\"}],\"modules\":[\"expo.modules.localauthentication.LocalAuthenticationModule\"]},{\"packageName\":\"expo-localization\",\"packageVersion\":\"15.0.3\",\"projects\":[{\"name\":\"expo-localization\",\"sourceDir\":\"../../packages/expo-localization/android\"}],\"modules\":[\"expo.modules.localization.LocalizationModule\"]},{\"packageName\":\"expo-location\",\"packageVersion\":\"17.0.1\",\"projects\":[{\"name\":\"expo-location\",\"sourceDir\":\"../../packages/expo-location/android\"}],\"modules\":[\"expo.modules.location.LocationModule\"]},{\"packageName\":\"expo-mail-composer\",\"packageVersion\":\"13.0.1\",\"projects\":[{\"name\":\"expo-mail-composer\",\"sourceDir\":\"../../packages/expo-mail-composer/android\"}],\"modules\":[\"expo.modules.mailcomposer.MailComposerModule\"]},{\"packageName\":\"expo-manifests\",\"packageVersion\":\"0.14.2\",\"projects\":[{\"name\":\"expo-manifests\",\"sourceDir\":\"../../packages/expo-manifests/android\"}],\"modules\":[]},{\"packageName\":\"expo-maps\",\"packageVersion\":\"0.4.0\",\"projects\":[{\"name\":\"expo-maps\",\"sourceDir\":\"../../packages/expo-maps/android\"}],\"modules\":[\"expo.modules.maps.ExpoGoogleMapsModule\"]},{\"packageName\":\"expo-media-library\",\"packageVersion\":\"16.0.3\",\"projects\":[{\"name\":\"expo-media-library\",\"sourceDir\":\"../../packages/expo-media-library/android\"}],\"modules\":[\"expo.modules.medialibrary.MediaLibraryModule\"]},{\"packageName\":\"expo-modules-core\",\"packageVersion\":\"1.12.11\",\"projects\":[{\"name\":\"expo-modules-core\",\"sourceDir\":\"../../packages/expo-modules-core/android\"}],\"modules\":[]},{\"packageName\":\"expo-navigation-bar\",\"packageVersion\":\"3.0.4\",\"projects\":[{\"name\":\"expo-navigation-bar\",\"sourceDir\":\"../../packages/expo-navigation-bar/android\"}],\"modules\":[\"expo.modules.navigationbar.NavigationBarModule\"]},{\"packageName\":\"expo-network\",\"packageVersion\":\"6.0.1\",\"projects\":[{\"name\":\"expo-network\",\"sourceDir\":\"../../packages/expo-network/android\"}],\"modules\":[\"expo.modules.network.NetworkModule\"]},{\"packageName\":\"expo-network-addons\",\"packageVersion\":\"0.6.0\",\"projects\":[{\"name\":\"expo-network-addons\",\"sourceDir\":\"../../packages/expo-network-addons/android\"}],\"plugins\":[{\"id\":\"expo-network-addons-gradle-plugin\",\"group\":\"expo.modules\",\"sourceDir\":\"../../packages/expo-network-addons/expo-network-addons-gradle-plugin\"}],\"modules\":[]},{\"packageName\":\"expo-notifications\",\"packageVersion\":\"0.28.1\",\"projects\":[{\"name\":\"expo-notifications\",\"sourceDir\":\"../../packages/expo-notifications/android\"}],\"modules\":[\"expo.modules.notifications.badge.BadgeModule\",\"expo.modules.notifications.notifications.background.ExpoBackgroundNotificationTasksModule\",\"expo.modules.notifications.notifications.categories.ExpoNotificationCategoriesModule\",\"expo.modules.notifications.notifications.channels.NotificationChannelGroupManagerModule\",\"expo.modules.notifications.notifications.channels.NotificationChannelManagerModule\",\"expo.modules.notifications.notifications.emitting.NotificationsEmitter\",\"expo.modules.notifications.notifications.handling.NotificationsHandler\",\"expo.modules.notifications.permissions.NotificationPermissionsModule\",\"expo.modules.notifications.notifications.presentation.ExpoNotificationPresentationModule\",\"expo.modules.notifications.notifications.scheduling.NotificationScheduler\",\"expo.modules.notifications.serverregistration.ServerRegistrationModule\",\"expo.modules.notifications.tokens.PushTokenModule\"]},{\"packageName\":\"expo-print\",\"packageVersion\":\"13.0.1\",\"projects\":[{\"name\":\"expo-print\",\"sourceDir\":\"../../packages/expo-print/android\"}],\"modules\":[\"expo.modules.print.PrintModule\"]},{\"packageName\":\"expo-random\",\"packageVersion\":\"14.0.1\",\"projects\":[{\"name\":\"expo-random\",\"sourceDir\":\"../../packages/expo-random/android\"}],\"modules\":[\"expo.modules.random.RandomModule\"]},{\"packageName\":\"expo-screen-capture\",\"packageVersion\":\"6.0.1\",\"projects\":[{\"name\":\"expo-screen-capture\",\"sourceDir\":\"../../packages/expo-screen-capture/android\"}],\"modules\":[\"expo.modules.screencapture.ScreenCaptureModule\"]},{\"packageName\":\"expo-screen-orientation\",\"packageVersion\":\"7.0.5\",\"projects\":[{\"name\":\"expo-screen-orientation\",\"sourceDir\":\"../../packages/expo-screen-orientation/android\"}],\"modules\":[\"expo.modules.screenorientation.ScreenOrientationModule\"]},{\"packageName\":\"expo-secure-store\",\"packageVersion\":\"13.0.1\",\"projects\":[{\"name\":\"expo-secure-store\",\"sourceDir\":\"../../packages/expo-secure-store/android\"}],\"modules\":[\"expo.modules.securestore.SecureStoreModule\"]},{\"packageName\":\"expo-sensors\",\"packageVersion\":\"13.0.6\",\"projects\":[{\"name\":\"expo-sensors\",\"sourceDir\":\"../../packages/expo-sensors/android\"}],\"modules\":[\"expo.modules.sensors.modules.AccelerometerModule\",\"expo.modules.sensors.modules.BarometerModule\",\"expo.modules.sensors.modules.GyroscopeModule\",\"expo.modules.sensors.modules.LightSensorModule\",\"expo.modules.sensors.modules.DeviceMotionModule\",\"expo.modules.sensors.modules.MagnetometerModule\",\"expo.modules.sensors.modules.MagnetometerUncalibratedModule\",\"expo.modules.sensors.modules.PedometerModule\"]},{\"packageName\":\"expo-sharing\",\"packageVersion\":\"12.0.1\",\"projects\":[{\"name\":\"expo-sharing\",\"sourceDir\":\"../../packages/expo-sharing/android\"}],\"modules\":[\"expo.modules.sharing.SharingModule\"]},{\"packageName\":\"expo-sms\",\"packageVersion\":\"12.0.1\",\"projects\":[{\"name\":\"expo-sms\",\"sourceDir\":\"../../packages/expo-sms/android\"}],\"modules\":[\"expo.modules.sms.SMSModule\"]},{\"packageName\":\"expo-speech\",\"packageVersion\":\"12.0.2\",\"projects\":[{\"name\":\"expo-speech\",\"sourceDir\":\"../../packages/expo-speech/android\"}],\"modules\":[\"expo.modules.speech.SpeechModule\"]},{\"packageName\":\"expo-splash-screen\",\"packageVersion\":\"0.27.4\",\"projects\":[{\"name\":\"expo-splash-screen\",\"sourceDir\":\"../../packages/expo-splash-screen/android\"}],\"modules\":[\"expo.modules.splashscreen.SplashScreenModule\"]},{\"packageName\":\"expo-sqlite\",\"packageVersion\":\"14.0.3\",\"projects\":[{\"name\":\"expo-sqlite\",\"sourceDir\":\"../../packages/expo-sqlite/android\"}],\"modules\":[\"expo.modules.sqlite.SQLiteModule\",\"expo.modules.sqlite.SQLiteModuleNext\"]},{\"packageName\":\"expo-store-review\",\"packageVersion\":\"7.0.2\",\"projects\":[{\"name\":\"expo-store-review\",\"sourceDir\":\"../../packages/expo-store-review/android\"}],\"modules\":[\"expo.modules.storereview.StoreReviewModule\"]},{\"packageName\":\"expo-structured-headers\",\"packageVersion\":\"3.8.0\",\"projects\":[{\"name\":\"expo-structured-headers\",\"sourceDir\":\"../../packages/expo-structured-headers/android\"}],\"modules\":[]},{\"packageName\":\"expo-symbols\",\"packageVersion\":\"0.1.4\",\"projects\":[{\"name\":\"expo-symbols\",\"sourceDir\":\"../../packages/expo-symbols/android\"}],\"modules\":[\"expo.modules.symbols.SymbolModule\"]},{\"packageName\":\"expo-system-ui\",\"packageVersion\":\"3.0.4\",\"projects\":[{\"name\":\"expo-system-ui\",\"sourceDir\":\"../../packages/expo-system-ui/android\"}],\"modules\":[\"expo.modules.systemui.SystemUIModule\"]},{\"packageName\":\"expo-task-manager\",\"packageVersion\":\"11.8.1\",\"projects\":[{\"name\":\"expo-task-manager\",\"sourceDir\":\"../../packages/expo-task-manager/android\"}],\"modules\":[\"expo.modules.taskManager.TaskManagerModule\"]},{\"packageName\":\"expo-tracking-transparency\",\"packageVersion\":\"4.0.2\",\"projects\":[{\"name\":\"expo-tracking-transparency\",\"sourceDir\":\"../../packages/expo-tracking-transparency/android\"}],\"modules\":[\"expo.modules.trackingtransparency.TrackingTransparencyModule\"]},{\"packageName\":\"expo-updates\",\"packageVersion\":\"0.25.12\",\"projects\":[{\"name\":\"expo-updates\",\"sourceDir\":\"../../packages/expo-updates/android\"}],\"plugins\":[{\"id\":\"expo-updates-gradle-plugin\",\"group\":\"expo.modules\",\"sourceDir\":\"../../packages/expo-updates/expo-updates-gradle-plugin\"}],\"modules\":[\"expo.modules.updates.UpdatesModule\"]},{\"packageName\":\"expo-updates-interface\",\"packageVersion\":\"0.16.2\",\"projects\":[{\"name\":\"expo-updates-interface\",\"sourceDir\":\"../../packages/expo-updates-interface/android\"}],\"modules\":[]},{\"packageName\":\"expo-video\",\"packageVersion\":\"1.1.9\",\"projects\":[{\"name\":\"expo-video\",\"sourceDir\":\"../../packages/expo-video/android\"}],\"modules\":[\"expo.modules.video.VideoModule\"]},{\"packageName\":\"expo-video-thumbnails\",\"packageVersion\":\"8.0.0\",\"projects\":[{\"name\":\"expo-video-thumbnails\",\"sourceDir\":\"../../packages/expo-video-thumbnails/android\"}],\"modules\":[\"expo.modules.videothumbnails.VideoThumbnailsModule\"]},{\"packageName\":\"expo-web-browser\",\"packageVersion\":\"13.0.3\",\"projects\":[{\"name\":\"expo-web-browser\",\"sourceDir\":\"../../packages/expo-web-browser/android\"}],\"modules\":[\"expo.modules.webbrowser.WebBrowserModule\"]},{\"packageName\":\"unimodules-app-loader\",\"packageVersion\":\"4.6.0\",\"projects\":[{\"name\":\"unimodules-app-loader\",\"sourceDir\":\"../../packages/unimodules-app-loader/android\"}],\"modules\":[]}]}",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "29e49a2480a7f3bb83185eaa939c88f9cfecfd4f"
}
] Generated by PR labeler 🤖 |
} | ||
|
||
Prop("tintColor") { view, color: Color? -> | ||
@RequiresApi(Build.VERSION_CODES.O) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we replace the RequiresApi
annotation if that checks the build version?
val type = split[0] | ||
val name = split[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val type = split[0] | |
val name = split[1] | |
val (type, name) = split |
Why
Adds initial support for material symbols on Android.
How
There are two options to do this. Download all the SVGs required and use the view system or use compose. I opted for compose.
Some outstanding issues
I haven't found any way yet to get a list of symbols or a way to group them.
Test Plan