Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update location.mdx #28809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[docs] Update location.mdx #28809

wants to merge 1 commit into from

Conversation

korpan
Copy link

@korpan korpan commented May 13, 2024

Why

copied code is different from visible snippet which is confusing and does not work

How

just change to mdx

Test Plan

compare code in snippet and what is copied by clicking copy

Checklist

copied code is different from visible snippet which is confusing and does not work
@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label May 13, 2024
@korpan korpan changed the title Update location.mdx [docs] Update location.mdx May 13, 2024
@amandeepmittal
Copy link
Member

When you mention copied code doesn't, do you mean you are copying the code from the block in a project on a local machine?

Assuming that's what you meant, we use expo-device package because it doesn't work on Expo Snack (snack.expo.dev). I can understand it can b confusing the copied code is different from what you are seeing so mentioning this in the example would be a good way to convey that info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants