[docs][sensors] Add note regarding running watchStepCount in background
#28798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behenate
requested review from
Simek,
amandeepmittal and
lukmccall
as code owners
amandeepmittal
approved these changes
May 13, 2024
behenate
force-pushed
the
@behenate/add-pedometer-note
branch
from
37f0c41
to
1a96960
Compare
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
lukmccall
approved these changes
May 27, 2024
fobos531
reviewed
May 27, 2024
| @@ -28,6 +28,10 @@ export type PedometerUpdateCallback = (result: PedometerResult) => void; | |||
| * provided with a single argument that is [`PedometerResult`](#pedometerresult). | |||
| * @return Returns a [`Subscription`](#subscription) that enables you to call | |||
| * `remove()` when you would like to unsubscribe the listener. | |||
| * | |||
| * > Pedometer updates will not be delivered while the app is in the background. As an alternative, on Android, use another solution based on | |||
| * > [`Health Connect API`](https://developers.google.com/fit) or [`Google Fit API`](https://developer.android.com/health-and-fitness/guides/health-connect). | |||
There was a problem hiding this comment.
@behenate The links are switched up - it should be the other way around. Also, it might be worth not recommending Google Fit API because as of right now, it is not even possible to sign up for the API (it is deprecated)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We should make the limitations of the Pedometer API clearer in the docs
ENG-11584