Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[font][Android] Stop scoping font names in Expo Go #28797

Merged
merged 4 commits into from
May 20, 2024

Conversation

lukmccall
Copy link
Contributor

@lukmccall lukmccall commented May 13, 2024

Why

Stops scoping font names in Expo Go on Android.
Matches iOS behavior.

Closes ENG-12069

How

Removed all scoping-related functions from expo-font.
Deprecated processFontFamily.

Test Plan

  • Expo Go ✅

@lukmccall lukmccall requested a review from tsapeta as a code owner May 13, 2024 11:13
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 13, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented May 13, 2024

The Pull Request introduced fingerprint changes against the base commit: 202f26a

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-font/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "1494e9d8d355c3f66ce23e0a650ef86bbe9f6557"
  }
]

Generated by PR labeler 🤖

Copy link

linear bot commented May 13, 2024

packages/expo-font/src/Font.ts Outdated Show resolved Hide resolved
lukmccall and others added 2 commits May 14, 2024 13:15
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@lukmccall lukmccall merged commit c9cfddc into main May 20, 2024
3 checks passed
@lukmccall lukmccall deleted the @lukmccall/font/remove-scoping branch May 20, 2024 13:11
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants