Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update templates for starting the tutorial and an Expo Router app #28766

Merged
merged 12 commits into from
May 14, 2024

Conversation

keith-kurak
Copy link
Contributor

Why

The default template now has Expo Router, but the tutorial assumes just an App.js file.

How

Updated the command to use the blank template. Long-term, it's surely better to update the entire tutorial to use the default template, but we really gotta go through and test that, and maybe adjust some things to account for the default template having multiple tabs we don't need, etc.

Also added a callout explaining why we're not using the default template. Maybe it's too much info, but I feel like a lot of people with big ideas trying to learn RN are going to think "what if I want a second screen?" so why not answer their question right away.

That lead me to also update the Router starter, as that refers to the SDK 50 tabs template.

Test Plan

Look at it

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label May 10, 2024
@keith-kurak
Copy link
Contributor Author

@amandeepmittal I tried to make Expo Router more prominent at the end of the tutorial. I also tried adding further context about templates in create-a-project. I've had several conversions on Discord now where folks are confused about whether or not they have to create a new app with Expo Router, so I think it would help to somehow make it more clear in most cases where we suggest creating a new project that you can create a new project with or without Expo Router.

@keith-kurak
Copy link
Contributor Author

also removed the Router compatibility table ... it seems redundant if you use npx expo install. Seems like maybe a vestige of when router wasn't in the monorepo.

docs/pages/router/installation.mdx Outdated Show resolved Hide resolved
docs/pages/router/installation.mdx Outdated Show resolved Hide resolved
docs/pages/tutorial/follow-up.mdx Outdated Show resolved Hide resolved
docs/pages/tutorial/follow-up.mdx Outdated Show resolved Hide resolved
@amandeepmittal
Copy link
Member

Long-term, it's surely better to update the entire tutorial to use the default template, but we really gotta go through and test that, and maybe adjust some things to account for the default template having multiple tabs we don't need, etc.

If we decide to update project structure of the Tutorial example app, sure we can. But we also need to consider (at the current stage) that using Expo Router library isn't supported with Snack and this tutorial right now, to provide a more beginner friendly experience relies heavily on Snack.

keith-kurak and others added 5 commits May 14, 2024 16:38
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
@keith-kurak keith-kurak merged commit 6786663 into main May 14, 2024
7 checks passed
@keith-kurak keith-kurak deleted the keith/adjust-starting-template-for-tutorial branch May 14, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants