Update create-expo-app CLI help screen and README to reflect new default template in v51 #28738
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned at https://expo.dev/changelog/2024/05-07-sdk-51#new-default-project-template-and-%22getting-started%22-flow, the default template changed from 'blank' to 'tabs'. This change just fixes the CLI help screen to reflect that.
zeckdude
changed the title
zeckdude
changed the title
zeckdude
changed the title
expo-bot
added
bot: passed checks
brentvatne
approved these changes
May 10, 2024
byCedric
reviewed
May 14, 2024
| @@ -38,7 +38,7 @@ async function run() { | |||
| [ | |||
| `-y, --yes Use the default options for creating a project`, | |||
| ` --no-install Skip installing npm packages or CocoaPods`, | |||
| chalk`-t, --template {gray [pkg]} NPM template to use: blank, tabs, bare-minimum. Default: blank`, | |||
| chalk`-t, --template {gray [pkg]} NPM template to use: default, blank, tabs, bare-minimum.`, | |||
There was a problem hiding this comment.
@brentvatne maybe we should omit this, we also support github URLs or tarbal paths with --template. That's not reflected here at all either.
There was a problem hiding this comment.
Wouldn't the more appropriate solution be to include all options here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As mentioned at https://expo.dev/changelog/2024/05-07-sdk-51#new-default-project-template-and-%22getting-started%22-flow, the default template changed from 'blank' to 'tabs'. This change just fixes the CLI help screen and README to reflect that.
How
Just fixed the instructions text
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).