Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][Android] Remove FontManagerModule #28720

Merged
merged 1 commit into from
May 21, 2024

Conversation

lukmccall
Copy link
Contributor

Why

Removes FontManagerModule and the underlaying internal interface. I think that using the react code directly in the expo-fonts is a better idea.

Test Plan

  • bare-expo ✅

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 9, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented May 9, 2024

The Pull Request introduced fingerprint changes against the base commit: 76c2f01

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-font/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "fd6718b8e7b1522e552dde9aa60847872dcae514"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "fdd5bd216a6c4ea46fa324cc776bcd800d9d493c"
  }
]

Generated by PR labeler 🤖

Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but please wait until brent start to publish packages from sdk-51 before merge.

@lukmccall lukmccall force-pushed the @lukmccall/core/remove-font-loader-module branch from 95ce633 to 3e5ac3c Compare May 20, 2024 13:40
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 3e5ac3c

@lukmccall lukmccall merged commit 56a028d into main May 21, 2024
14 checks passed
@lukmccall lukmccall deleted the @lukmccall/core/remove-font-loader-module branch May 21, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants