Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core][Android] Remove RuntimeEnviromentModule #28719

Merged
merged 2 commits into from
May 20, 2024

Conversation

lukmccall
Copy link
Contributor

Why

Removes RuntimeEnviromentModule

How

It was only obtained from the module registry (in expo-gl) without any further usage. We can remove it.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 9, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented May 9, 2024

The Pull Request introduced fingerprint changes against the base commit: 3f2a537

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-gl",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "a8ed5fe550121cf2ed794797b0c8eff335613856"
  },
  {
    "type": "dir",
    "filePath": "../../packages/expo-modules-core",
    "reasons": [
      "expoAutolinkingIos",
      "expoAutolinkingAndroid"
    ],
    "hash": "9a52735083802b1bf3cb5021150326e4524ab4b1"
  }
]

Generated by PR labeler 🤖

@expo-bot
Copy link
Collaborator

expo-bot commented May 9, 2024

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against cb160c4

Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but please wait until brent start to publish packages from sdk-51 before merge.

@lukmccall lukmccall merged commit 76c2f01 into main May 20, 2024
13 checks passed
@lukmccall lukmccall deleted the @lukmccall/core/remove-runtime-enviromentmodule branch May 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants