-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sensors][Android] Remove usage of InternalModule
#28715
Conversation
The Pull Request introduced fingerprint changes against the base commit: 76c2f01 Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "ce9cca987470dc6cd44c831ca843b83fdd045ee6"
},
{
"type": "dir",
"filePath": "../../packages/expo-sensors/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "b438a52ec63758b613527478f4aaf1b652fab086"
}
] Generated by PR labeler 🤖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but please wait until brent start to publish packages from sdk-51 before merge.
7b6fe96
to
cbbdb8b
Compare
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Why
Removes usage of
InternalModule
in theexpo-sensor
package.That change made the code more readable, in my opinion.
How
We are currently migrating from an old module API. All Android modules have successfully switched to the new API to export functonality to JS. However, some parts remain untouched and still utilize the unimodules infrastructure.
Test Plan