[router] fix typed routes sometimes having trailing slash #28707
+20
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklawlor
commented
May 9, 2024
| @@ -81,21 +81,14 @@ it('allows spaces in the filename', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('expands groups', () => { | |||
There was a problem hiding this comment.
This is duplicate test
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Routes with grouped nested within non-group folders can have a typed route generated with a trailing slash
How
Ensure the slash is removed
Test Plan
Added test cases
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).