Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Use Node 20.10.0+ for check-packages #25709

Merged
merged 1 commit into from
Dec 2, 2023
Merged

[ci] Use Node 20.10.0+ for check-packages #25709

merged 1 commit into from
Dec 2, 2023

Commits on Dec 2, 2023

  1. [ci] Use Node 20.10.0+ for check-packages 

    Why
---
Node 20.10.0 includes a memory leak fix in V8's compilation cache. This matters for Jest test suites, which repeatedly discard and reload the environment. See jestjs/jest#11956.

How
---
Used setup-node to explicitly install Node 20. Getting the latest version will include the V8 fix. Also upgraded the checkout action (breaking change is that it uses Node 20 itself internally).

If this works well, we could consider using setup-node's own Yarn node_modules caching instead of our own but that is out of the scope of this PR.

Test Plan
---
Make sure this passes in CI.
    @ide
    ide committed Dec 2, 2023
    Configuration menu
    Copy the full SHA
    21a2351 View commit details
    Browse the repository at this point in the history