Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): simplify Metro watch mode and communicate when disabled #20939

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jan 24, 2023

Why

Fixes ENG-7089

How

Because this option is only exposed through Metro.runServer, I added the override in @expo/cli. Alternative, we could add a custom Metro config option to move this to the config itself, however, that would create a significant diversion of the normal Metro config.

Note
We could add a Metro version check and disable the warning, but I think it's safe to skip that and leave it in for older Metro versions. It's not really synced, but if the message pops up, it's very very likely Metro actually is running without watch.

Test Plan

See added tests.

Checklist

@linear
Copy link

linear bot commented Jan 24, 2023

ENG-7089 Override Metro's watch option

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 24, 2023
Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need changelog

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 25, 2023
@byCedric byCedric merged commit 0f61c87 into main Jan 25, 2023
@byCedric byCedric deleted the @bycedric/metro-config/enhance-watcher-mode-for-ci branch January 25, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants