Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ncl][expo] update react-native-skia to 0.1.157 #19789

Merged
merged 2 commits into from Oct 31, 2022
Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Oct 31, 2022

Why

fix Shopify/react-native-skia#1030 for sdk 47

How

  • there're no meaningful native changes from 0.1.155 to 0.1.157, so we just update the bundledNativeModules.json
  • revert the NCL webpack workaround from [NCL] Fix skia web support #19717

Test Plan

  • tested on sdk 47 expo go + @shopify/react-native-skia@0.1.157
  • NCL ci passed
  • NCL - yarn build:web

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 31, 2022
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against 84b6389

@expo-bot expo-bot added bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Oct 31, 2022
@Kudo Kudo marked this pull request as ready for review October 31, 2022 18:03
@Kudo Kudo requested review from ide and tsapeta as code owners October 31, 2022 18:03
@Kudo Kudo merged commit 43cf22e into main Oct 31, 2022
@Kudo Kudo deleted the @kudo/sdk47/skia-0.1.157 branch October 31, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The JS files are incompatible with Expo Web
3 participants