Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][Android] Upgrade react-native-gesture-handler to 2.8.0 #19654

Merged
merged 2 commits into from Oct 21, 2022

Conversation

lukmccall
Copy link
Contributor

Why

Upgrade react-native-gesture-handler to 2.8.0.
Connected with https://exponent-internal.slack.com/archives/CNHBN8LNS/p1666255180108099.

How

et update-vendored-module -m react-native-gesture-handler -c main

Test Plan

  • NCL in expo go ✅

@lukmccall lukmccall requested a review from Kudo October 21, 2022 15:30
@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 21, 2022
CHANGELOG.md Outdated
@@ -13,7 +13,7 @@ Package-specific changes not released in any SDK will be added here just before
- Updated `@shopify/flash-list` from `1.1.0` to `1.3.0`. ([#19317](https://github.com/expo/expo/pull/19317) by [@kudo](https://github.com/kudo))
- Updated `react-native-view-shot` from `3.3.0` to `3.4.0`. ([#19405](https://github.com/expo/expo/pull/19405) by [@douglowder](https://github.com/douglowder))
- Updated `react-native-webview` from `11.23.0` to `11.23.1`. ([#19375](https://github.com/expo/expo/pull/19375) by [@aleqsio](https://github.com/aleqsio))
- Updated `react-native-gesture-handler` from `2.5.0` to `2.7.0`. ([#19362](https://github.com/expo/expo/pull/19362) by [@tsapeta](https://github.com/tsapeta))
- Updated `react-native-gesture-handler` from `2.5.0` to `2.8.0`. ([#19362](https://github.com/expo/expo/pull/19362) by [@tsapeta](https://github.com/tsapeta))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could also add the pr to this changelog item.

CHANGELOG.md Outdated Show resolved Hide resolved
@lukmccall lukmccall merged commit e5f0011 into main Oct 21, 2022
@lukmccall lukmccall deleted the @lukmccall/gesture-handler/upgrade-to-2_11 branch October 21, 2022 17:11
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against 3b87568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants