Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][Android] Update reanimated to 2.11.0 #19602

Merged
merged 4 commits into from Oct 19, 2022
Merged

[iOS][Android] Update reanimated to 2.11.0 #19602

merged 4 commits into from Oct 19, 2022

Conversation

lukmccall
Copy link
Contributor

Why

Closes ENG-6530.

How

  • Adjusted the vendored process to use the new version of the script on Android.
  • Run et update-vendored-module -m react-native-reanimated
  • Made sure that the integration between the reanimated and the gesture-handler still works

Test Plan

  • bare-expo with NCL ✅

@lukmccall lukmccall requested a review from Kudo October 18, 2022 14:59
@linear
Copy link

linear bot commented Oct 18, 2022

ENG-6530 react-native-reanimated

Kudo
Kudo reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the android/expoview/build.gradle is super clear now. great improvement for the new vendoring. i just leave some nit comments as following.

android/vendored/unversioned/react-native-reanimated/android/README.md Outdated Show resolved Hide resolved
...ative-reanimated/android/rnVersionPatch/62/layoutReanimation/ReanimatedUIImplementation.java Outdated Show resolved Hide resolved
tools/src/vendoring/config/expoGoConfig.ts Outdated Show resolved Hide resolved
@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 19, 2022
tsapeta
tsapeta approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work, thanks for moving reanimated to the new vendoring mechanism and clearing up expoview 👍

Kudo
Kudo reviewed Oct 19, 2022
View reviewed changes
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also spotlessApply to fix android unit test failures

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:

Generated by ExpoBot 🤖 against e37708c

@lukmccall lukmccall merged commit 04819bf into main Oct 19, 2022
@lukmccall lukmccall deleted the @lukmccall/reanimated/upgrade branch October 19, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kudo Kudo Kudo approved these changes

@tsapeta tsapeta tsapeta approved these changes

@ide ide Awaiting requested review from ide ide is a code owner

@brentvatne brentvatne Awaiting requested review from brentvatne brentvatne is a code owner

Assignees
No one assigned
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukmccall @expo-bot @Kudo @tsapeta