Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS][Android] Update react-native-svg to 13.4.0 #19434

Merged
merged 2 commits into from Oct 11, 2022
Merged

[iOS][Android] Update react-native-svg to 13.4.0 #19434

merged 2 commits into from Oct 11, 2022

Conversation

lukmccall
Copy link
Contributor

@lukmccall lukmccall commented Oct 6, 2022 •
edited

Why

Closes ENG-6532.

How

Run:

 et uvm -m react-native-svg

Note:
This version of SVG requires a new version of the home app. It will be created later because I faced other problems with the home app - see #19495

Test Plan

  • home - android, ios ✅
  • NCL - android, ios ✅

@linear
Copy link

linear bot commented Oct 6, 2022

ENG-6532 react-native-svg

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 6, 2022
@ilteoood ilteoood mentioned this pull request Oct 7, 2022
Open
@Simek
Copy link
Collaborator

Simek commented Oct 9, 2022

Superseed #19080

@Simek
Copy link
Collaborator

Simek commented Oct 9, 2022 •
edited

Do we still need the patch file for children in types?

@lukmccall lukmccall force-pushed the @lukmccall/bump-svg branch 2 times, most recently from 4483eec to cb0c370 Compare October 11, 2022 11:28
@lukmccall lukmccall changed the title [iOS][Android] Update react-native-svg to 13.3.0 [iOS][Android] Update react-native-svg to 13.4.0 Oct 11, 2022
@lukmccall
Copy link
Contributor Author

Do we still need the patch file for children in types?

It seems to be needed 🤷

@lukmccall lukmccall marked this pull request as ready for review October 11, 2022 11:31
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:

Generated by ExpoBot 🤖 against 7c7ed45

@lukmccall lukmccall merged commit 7ac216e into main Oct 11, 2022
@lukmccall lukmccall deleted the @lukmccall/bump-svg branch October 11, 2022 14:33
@pweisensee pweisensee mentioned this pull request Oct 12, 2022
Merged
3 tasks
lukmccall pushed a commit that referenced this pull request Oct 13, 2022
@pweisensee
Update CHANGELOG.md react-native-svg to 13.4.0 (#19531)
db3ea19 
# Why

`CHANGELOG.md` has incorrect version of dependency `react-native-svg` from recent PR #19434

# How

Did not build or test (N/A)

# Test Plan

Did not build or test (N/A)

# Checklist


- [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `expo prebuild` & EAS Build (eg: updated a module plugin).
@zakharchenkoAndrii
Copy link
Contributor

zakharchenkoAndrii commented Dec 6, 2022 •
edited

Is that possible to bump version of react-native-svg to 13.6.0?

Asking because we have a crash on android on 13.4 version:
java.lang.Double cannot be cast to abi47_0_0.com.facebook.react.bridge.ReadableMap

When 13.4 installed bare RN crashes with this error, bumping to 13.6 fixes native crash but when I launch it in Expo go we have this issue... I suspect (hope) that it will resolve the issue.

upd: seems like smth related to react-native-svg-transformer...
we use fill property to dynamicly change the color of svg. And when this property is empty string - the app crashes on 13.4 version but still works on 13.6

cc/ @lukmccall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta approved these changes

@ide ide Awaiting requested review from ide ide is a code owner

@brentvatne brentvatne Awaiting requested review from brentvatne brentvatne is a code owner

@ajsmth ajsmth Awaiting requested review from ajsmth

Assignees
No one assigned
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lukmccall @Simek @expo-bot @zakharchenkoAndrii @tsapeta