Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][ios] Upgrade lottie-react-native to 5.1.4 #19433

Merged
merged 6 commits into from Oct 7, 2022

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Oct 6, 2022

Why

close ENG-6540

How

  • et uvm -m lottie-react-native -c v5.1.4
  • backport lottie-ios version bump to versioned code

Test Plan

should apply this pr first: #19439

  • android unversioned expo go + NCL lottie
  • ios unversioned expo go + NCL lottie

Checklist

@linear
Copy link

linear bot commented Oct 6, 2022

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 6, 2022
@Kudo Kudo force-pushed the @kudo/sdk47/vendor-lottie branch from 3693aa1 to edf69cd Compare October 6, 2022 15:21
@Kudo Kudo marked this pull request as ready for review October 6, 2022 19:02
@Kudo Kudo removed request for brentvatne and ide October 6, 2022 19:02
ios/ExpoKit.podspec Show resolved Hide resolved
@Kudo Kudo merged commit e3115b1 into main Oct 7, 2022
@Kudo Kudo deleted the @kudo/sdk47/vendor-lottie branch October 7, 2022 14:22
@expo-bot
Copy link
Collaborator

expo-bot commented Oct 7, 2022

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against ca94202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants