Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][ios] Upgrade @react-native-community/slider to 4.2.4 #19424

Merged
merged 8 commits into from Oct 7, 2022

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Oct 6, 2022

Why

close ENG-6538

the latest slider version is v4.3.2, but it is incompatible with reanimated layout animation setup. mainly because it uses the dispatchModern. as we doesn't support fabric on android expo go, it should be fine to not upgrade slider 4.3 which is mainly for fabric support.

How

  • update to new style vendoring
  • et uvm -m @react-native-community/slider -c v4.2.4 -p android
  • et uvm -m @react-native-community/slider -c v4.2.4 -p ios

Test Plan

  • android unversioned expo go + NCL slider
  • ios unversioned expo go + NCL slider

Checklist

@linear
Copy link

linear bot commented Oct 6, 2022

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 6, 2022
@Kudo Kudo marked this pull request as ready for review October 6, 2022 06:31
@Kudo Kudo removed request for brentvatne and ide October 6, 2022 06:31
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for migrating this package! 🙏

tools/src/vendoring/config/expoGoConfig.ts Show resolved Hide resolved
@Kudo Kudo merged commit d58f61a into main Oct 7, 2022
@Kudo Kudo deleted the @kudo/eng-6538-react-native-communityslider branch October 7, 2022 14:25
@expo-bot
Copy link
Collaborator

expo-bot commented Oct 7, 2022

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against e2662f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants