Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][iOS] Upgrade @react-native-community/netinfo to 9.3.3 #19421

Merged
merged 2 commits into from Oct 5, 2022

Conversation

douglowder
Copy link
Contributor

Why

Closes ENG-6543

How

et uvm -m @react-native-community/netinfo -c 'v9.3.3'
et pods -f
yarn

Test Plan

  • test unversioned expo go ios
  • test unversioned expo go android
  • CI tests pass

Checklist

@linear
Copy link

linear bot commented Oct 5, 2022

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 5, 2022
@expo-bot
Copy link
Collaborator

expo-bot commented Oct 5, 2022

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against fec522e

@expo-bot expo-bot added bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Oct 5, 2022
@douglowder
Copy link
Contributor Author

iOS unit test failure is in EXUpdatesErrorRecovery and seems unrelated to this change.

@douglowder douglowder merged commit 446555c into main Oct 5, 2022
@douglowder douglowder deleted the doug/eng-6543-react-native-communitynetinfo branch October 5, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants