New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android][iOS] Upgrade react-native-view-shot to 3.4.0 #19405
Conversation
Restoring previous patch to RNViewShot.m that is still not present in 3.4.0 |
2f88c24
to
4fee1a6
Compare
@lukmccall when you get a chance, please have a look at this upgrade -- |
...xpoview/src/main/java/versioned/host/exp/exponent/modules/api/viewshot/RNViewShotModule.java
Outdated
Show resolved
Hide resolved
...xpoview/src/main/java/versioned/host/exp/exponent/modules/api/viewshot/RNViewShotModule.java
Outdated
Show resolved
Hide resolved
345a608
to
1ba030c
Compare
Ok @lukmccall @tsapeta I've restored the use of scoped context, and after going through the rest of the code in expoview, I've removed |
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: Changelog entry in wrong CHANGELOG file
Generated by ExpoBot 🤖 against 1ba030c |
Why
Closes ENG-6541
How
Test Plan
Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).