Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][iOS] Upgrade react-native-view-shot to 3.4.0 #19405

Merged
merged 7 commits into from Oct 6, 2022

Conversation

douglowder
Copy link
Contributor

@douglowder douglowder commented Oct 5, 2022

Why

Closes ENG-6541

How

et uvm -m react-native-view-shot -c 'v3.4.0'
et pods -f
yarn

Test Plan

  • test unversioned expo go ios
  • test unversioned expo go android
  • CI tests pass

Checklist

@linear
Copy link

linear bot commented Oct 5, 2022

@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Oct 5, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@douglowder
Copy link
Contributor Author

douglowder commented Oct 5, 2022

Restoring previous patch to RNViewShot.m that is still not present in 3.4.0

@douglowder douglowder force-pushed the doug/eng-6541-react-native-view-shot branch from 2f88c24 to 4fee1a6 Compare October 5, 2022 19:22
@douglowder
Copy link
Contributor Author

@lukmccall when you get a chance, please have a look at this upgrade -- et uvm removed Expo-specific changes to the Android module. I've restored them, but would appreciate an additional review to make sure nothing was missed.

@douglowder douglowder force-pushed the doug/eng-6541-react-native-view-shot branch from 345a608 to 1ba030c Compare October 6, 2022 16:40
@douglowder
Copy link
Contributor Author

Ok @lukmccall @tsapeta I've restored the use of scoped context, and after going through the rest of the code in expoview, I've removed RNViewShotPackage.java because we don't seem to be using that file.

@expo-bot
Copy link
Collaborator

expo-bot commented Oct 6, 2022

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against 1ba030c

@douglowder douglowder merged commit 366e33a into main Oct 6, 2022
@douglowder douglowder deleted the doug/eng-6541-react-native-view-shot branch October 6, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants