Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][ios] Upgrade react-native-safe-area-context to 4.4.1 #19401

Merged
merged 4 commits into from Oct 7, 2022

Conversation

brentvatne
Copy link
Member

@brentvatne brentvatne commented Oct 4, 2022

Why

Closes ENG-6542

How

et uvm -m react-native-safe-area-context -c 'v4.4.1'
et pods -f
yarn

Test Plan

  • test unversioned expo go ios + NCL safe area context
  • test unversioned expo go android + NCL safe area context

Checklist

@linear
Copy link

linear bot commented Oct 4, 2022

@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: needs changes ExpoBot found things that don't meet our guidelines and removed bot: suggestions ExpoBot has some suggestions labels Oct 4, 2022
ios/Podfile.lock Outdated
@@ -3444,7 +3444,7 @@ SPEC CHECKSUMS:
FirebaseCoreInternal: bca76517fe1ed381e989f5e7d8abb0da8d85bed3
FirebaseInstallations: 0a115432c4e223c5ab20b0dbbe4cbefa793a0e8e
fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9
glog: 04b94705f318337d7ead9e6d17c019bd9b1f6b1b
glog: 3d02b25ca00c2d456734d0bcff864cbc62f6ae1a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik this is incorrect, remove the Pods folder and reinstall pods.

@brentvatne brentvatne force-pushed the @brent/update-react-native-safe-area-context branch from cc2ccc6 to 85d5bfb Compare October 6, 2022 22:46
@brentvatne brentvatne force-pushed the @brent/update-react-native-safe-area-context branch from 1e544c1 to ce51fa5 Compare October 7, 2022 03:30
@expo-bot
Copy link
Collaborator

expo-bot commented Oct 7, 2022

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against ce51fa5

@brentvatne
Copy link
Member Author

it looks like we're getting the same test failure on main, so merging this

@brentvatne brentvatne merged commit 70f3eff into main Oct 7, 2022
@brentvatne brentvatne deleted the @brent/update-react-native-safe-area-context branch October 7, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants