New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios][android] Update react-native-screens to 3.18.0 #19383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
changed the title
[ios][android] Update react-native-screens to 3.17.0
[ios][android] Update react-native-screens to 3.18.0
Oct 4, 2022
tsapeta
force-pushed
the
@tsapeta/update-rn-screens
branch
from
October 4, 2022 12:47
756d3df
to
b1aa83f
Compare
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Oct 4, 2022
tsapeta
force-pushed
the
@tsapeta/update-rn-screens
branch
from
October 5, 2022 10:17
b1aa83f
to
0e16717
Compare
Kudo
reviewed
Oct 5, 2022
...d/vendored/unversioned/react-native-screens/android/gradle/wrapper/gradle-wrapper.properties
Outdated
Show resolved
Hide resolved
android/vendored/unversioned/react-native-screens/android/gradlew
Outdated
Show resolved
Hide resolved
android/vendored/unversioned/react-native-screens/android/gradlew.bat
Outdated
Show resolved
Hide resolved
android/vendored/unversioned/react-native-screens/android/settings.gradle
Outdated
Show resolved
Hide resolved
android/vendored/unversioned/react-native-screens/android/spotless.gradle
Outdated
Show resolved
Hide resolved
...ndored/unversioned/react-native-screens/android/src/main/res/anim/rns_slide_in_from_left.xml
Outdated
Show resolved
Hide resolved
...dored/unversioned/react-native-screens/android/src/main/res/anim/rns_slide_in_from_right.xml
Outdated
Show resolved
Hide resolved
...dored/unversioned/react-native-screens/android/src/main/res/anim/rns_slide_out_to_bottom.xml
Outdated
Show resolved
Hide resolved
...endored/unversioned/react-native-screens/android/src/main/res/anim/rns_slide_out_to_left.xml
Outdated
Show resolved
Hide resolved
...ndored/unversioned/react-native-screens/android/src/main/res/anim/rns_slide_out_to_right.xml
Outdated
Show resolved
Hide resolved
tsapeta
force-pushed
the
@tsapeta/update-rn-screens
branch
from
October 5, 2022 13:43
0e16717
to
5260f46
Compare
tsapeta
force-pushed
the
@tsapeta/update-rn-screens
branch
from
October 5, 2022 13:54
5260f46
to
2452beb
Compare
Kudo
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Updating vendored code for SDK 47
Closes ENG-6531
How
android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/screens
and related view managers fromandroid/expoview/src/main/java/com/facebook/react/viewmanagers
host.exp.expoview.BuildConfig
andhost.exp.expoview.R
which is not needed now as it's been moved to a separate libraryet uvm -m react-native-screens
Test Plan
Navigation in Expo Go seems to work fine. NCL examples work as expected too.