Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios][android] Update react-native-screens to 3.18.0 #19383

Merged
merged 8 commits into from Oct 5, 2022

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Oct 4, 2022

Why

Updating vendored code for SDK 47
Closes ENG-6531

How

  • Enabled new vendoring approach for react-native-screens on Android
  • Deleted previously vendored code from android/expoview/src/main/java/versioned/host/exp/exponent/modules/api/screens and related view managers from android/expoview/src/main/java/com/facebook/react/viewmanagers
  • Previous code transformations are not necessary now — they were only adding imports for host.exp.expoview.BuildConfig and host.exp.expoview.R which is not needed now as it's been moved to a separate library
  • et uvm -m react-native-screens

Test Plan

Navigation in Expo Go seems to work fine. NCL examples work as expected too.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 4, 2022
@tsapeta tsapeta changed the title [ios][android] Update react-native-screens to 3.17.0 [ios][android] Update react-native-screens to 3.18.0 Oct 4, 2022
@tsapeta tsapeta marked this pull request as ready for review October 4, 2022 12:48
@linear
Copy link

linear bot commented Oct 4, 2022

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 4, 2022
@tsapeta tsapeta requested a review from Kudo October 5, 2022 10:21
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@tsapeta tsapeta merged commit dee909a into main Oct 5, 2022
@tsapeta tsapeta deleted the @tsapeta/update-rn-screens branch October 5, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants