[ios][android] Update react-native-gesture-handler to 2.7.0 #19362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsapeta
force-pushed
the
@tsapeta/update-gesture-handler
branch
from
f112535
to
bb1ae89
Compare
expo-bot
added
bot: needs changes
tsapeta
force-pushed
the
@tsapeta/update-gesture-handler
branch
from
bb1ae89
to
d7fa30f
Compare
expo-bot
added
bot: passed checks
tsapeta
changed the title
tsapeta
force-pushed
the
@tsapeta/update-gesture-handler
branch
from
d7fa30f
to
1af1c34
Compare
Kudo
reviewed
Oct 5, 2022
| cmake { | ||
| cppFlags "-O2 -frtti -fexceptions -Wall -Wno-unused-variable -fstack-protector-all" | ||
| arguments "-DAPP_BUILD_DIR=${appProject.buildDir}", | ||
| "-DREACT_NATIVE_DIR=${REACT_NATIVE_DIR}", |
There was a problem hiding this comment.
oh no! gesture-handler has cpp code now, even though it's for fabric only 🤦♂️
that would increase the complexity in versioning the vendored module.
i'm just taking a note that i should aware of this 😅
Kudo
approved these changes
Oct 5, 2022
| @@ -58,6 +58,7 @@ const config: VendoringTargetConfig = { | |||
| source: 'https://github.com/software-mansion/react-native-gesture-handler.git', | |||
| semverPrefix: '~', | |||
| ios: {}, | |||
| android: {}, | |||
There was a problem hiding this comment.
would you like to remove the vendoring code in legacy.ts ?
There was a problem hiding this comment.
I planned to do that, but there are more libs to delete from there, so I'll do that separately
tsapeta
force-pushed
the
@tsapeta/update-gesture-handler
branch
from
1af1c34
to
b84558e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Upgrading the gesture handler for SDK 47
Closes ENG-6529
How
react-native-gesture-handlerto the new vendoring mechanismlib/build.gradlefrom the source code so our vendored autolinking doesn't detect this as a separate library. This build.gradle should and will get removed from the repo (it's not used and uses pretty old versions that don't compile)et uvm -m react-native-gesture-handler -c 2.7.0Test Plan
NCL examples seem to work fine