Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android][ios] Upgrade @shopify/react-native-skia to 0.1.153 #19360

Merged
merged 7 commits into from Oct 6, 2022

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Oct 3, 2022

Why

close ENG-6536

How

  • [tools] Update react-native-skia.patch
  • et uvm -m @shopify/react-native-skia -c 0.1.153
  • [NCL] update SkiaScreen example mainly for useDerivedValue -> useComputedValue

Test Plan

  • android unversioned expo go + NCL skia
  • ios unversioned expo go + NCL skia

Checklist

@linear
Copy link

linear bot commented Oct 3, 2022

@expo-bot expo-bot added the bot: needs changes ExpoBot found things that don't meet our guidelines label Oct 3, 2022
@Kudo Kudo marked this pull request as ready for review October 3, 2022 12:14
@Kudo Kudo removed request for brentvatne and ide October 3, 2022 12:14
@Kudo Kudo force-pushed the @kudo/eng-6536-shopifyreact-native-skia branch from 2ec5d15 to 2a2d08d Compare October 6, 2022 03:43
@Kudo Kudo merged commit 56fe5e7 into main Oct 6, 2022
@expo-bot
Copy link
Collaborator

expo-bot commented Oct 6, 2022

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

❌ Error: Changelog entry in wrong CHANGELOG file


Your changelog entries should be noted in package-specific changelogs. Read Updating Changelogs guide and move changelog entries from the global CHANGELOG.md to the following changelogs:


Generated by ExpoBot 🤖 against 2a2d08d

@Kudo Kudo deleted the @kudo/eng-6536-shopifyreact-native-skia branch October 6, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: needs changes ExpoBot found things that don't meet our guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants