Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Bump deployment target to 13.0 #18873

Merged
merged 3 commits into from Sep 14, 2022

Conversation

tsapeta
Copy link
Member

@tsapeta tsapeta commented Aug 29, 2022

Why

We're dropping support for iOS 12 in SDK47
Closes ENG-6041

How

Bumped the minimum iOS version:

  • in all podspecs (packages folder + ExpoKit)
  • Podfiles
  • Xcode workspaces (projects and targets) in apps folder
  • bare-minimum template

Test Plan

CI jobs are passing, Expo Go and bare-expo compiles as expected

@linear
Copy link

linear bot commented Aug 29, 2022

ENG-6041 Drop iOS 12

As of SDK 46 we only support iOS 12.4+ but in SDK 47 we will drop 12 entirely

We'll also bump Swift but not to the latest (5.7) - just to 5.6.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 29, 2022
@tsapeta tsapeta force-pushed the @tsapeta/ios/bump-deployment-target-13.0 branch 3 times, most recently from 01e6e5c to 6d39d50 Compare August 30, 2022 08:05
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Aug 30, 2022
@tsapeta tsapeta force-pushed the @tsapeta/ios/bump-deployment-target-13.0 branch from 6d39d50 to db8c844 Compare August 31, 2022 09:38
@tsapeta tsapeta marked this pull request as ready for review September 2, 2022 09:00
@wschurman wschurman removed their request for review September 2, 2022 16:43
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the expo-build-properties for me 🤩

@tsapeta tsapeta force-pushed the @tsapeta/ios/bump-deployment-target-13.0 branch from db8c844 to 641edad Compare September 8, 2022 16:10
@tsapeta tsapeta force-pushed the @tsapeta/ios/bump-deployment-target-13.0 branch from 641edad to 3e025e0 Compare September 13, 2022 22:08
@tsapeta tsapeta merged commit c88b85c into main Sep 14, 2022
@tsapeta tsapeta deleted the @tsapeta/ios/bump-deployment-target-13.0 branch September 14, 2022 07:55
Ddv0623 pushed a commit to preciofishbone/expo that referenced this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants