New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ios] Bump deployment target to 13.0 #18873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-6041 Drop iOS 12
As of SDK 46 we only support iOS 12.4+ but in SDK 47 we will drop 12 entirely We'll also bump Swift but not to the latest (5.7) - just to 5.6. |
tsapeta
force-pushed
the
@tsapeta/ios/bump-deployment-target-13.0
branch
3 times, most recently
from
August 30, 2022 08:05
01e6e5c
to
6d39d50
Compare
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Aug 30, 2022
tsapeta
force-pushed
the
@tsapeta/ios/bump-deployment-target-13.0
branch
from
August 31, 2022 09:38
6d39d50
to
db8c844
Compare
tsapeta
requested review from
ide,
brentvatne,
barthap,
esamelson,
wschurman,
douglowder,
byCedric,
EvanBacon,
Kudo,
lukmccall,
wkozyra95 and
ajsmth
as code owners
September 2, 2022 09:00
tsapeta
removed request for
ide,
barthap,
esamelson,
douglowder,
byCedric,
EvanBacon,
wkozyra95 and
ajsmth
September 6, 2022 12:29
Kudo
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating the expo-build-properties for me 🤩
lukmccall
approved these changes
Sep 8, 2022
tsapeta
force-pushed
the
@tsapeta/ios/bump-deployment-target-13.0
branch
from
September 8, 2022 16:10
db8c844
to
641edad
Compare
tsapeta
force-pushed
the
@tsapeta/ios/bump-deployment-target-13.0
branch
from
September 13, 2022 22:08
641edad
to
3e025e0
Compare
Ddv0623
pushed a commit
to preciofishbone/expo
that referenced
this pull request
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We're dropping support for iOS 12 in SDK47
Closes ENG-6041
How
Bumped the minimum iOS version:
Test Plan
CI jobs are passing, Expo Go and bare-expo compiles as expected