Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react-native 0.69 #18006

Merged
merged 25 commits into from Jun 29, 2022
Merged

Upgrade to react-native 0.69 #18006

merged 25 commits into from Jun 29, 2022

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jun 28, 2022

Why

for sdk 46
close ENG-5353

How

Test Plan

  • android bare-expo smoke test
  • ios bare-expo smoke test
  • ci passed
    • updates e2e is broken because in the flow the react-native doesn't include 0.69.1 fixes.

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 28, 2022
@Kudo Kudo force-pushed the @kudo/rn069-bare-expo branch 2 times, most recently from 159ec02 to 4b14bd9 Compare June 28, 2022 13:03
@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 6580e64

@Kudo Kudo marked this pull request as ready for review June 28, 2022 16:51
@Kudo
Copy link
Contributor Author

Kudo commented Jun 29, 2022

to unblock the vendoring modules schedule for this sdk, i am going to merge this pr directly. feel free to give me comment from post review by any chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants