[cli] Added auth commands to expo #16087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update otp.ts Update actions.ts
EvanBacon
force-pushed
the
@evanbacon/expo/cli/auth-commands
branch
from
c7bc1c0
to
d6e17c4
Compare
drop amplitude Update rudderstackClient.ts
EvanBacon
force-pushed
the
@evanbacon/expo/cli/auth-commands
branch
from
bd71031
to
5ef009a
Compare
ide
reviewed
Jan 27, 2022
| 'expo-session': string; | ||
| }; | ||
|
|
||
| export const graphqlClient = createUrqlClient({ |
There was a problem hiding this comment.
I know this is orthogonal to this PR but I would like to fix/get rid of that CombinedError message later unless there truly are multiple errors, in which case there is still probably a nicer way to print them than with [CombinedError]
byCedric
reviewed
Jan 27, 2022
kbrandwijk
reviewed
Jan 27, 2022
Co-authored-by: James Ide <ide@users.noreply.github.com> Co-authored-by: Cedric van Putten <me@bycedric.com>
EvanBacon
commented
Jan 27, 2022
EvanBacon
force-pushed
the
@evanbacon/expo/cli/auth-commands
branch
from
d20c928
to
8fd8e42
Compare
Update registerAsync.ts Remove unused settings Drop unused Update otp.ts Update whoamiAsync.ts
EvanBacon
force-pushed
the
@evanbacon/expo/cli/auth-commands
branch
from
cbeaabe
to
979519b
Compare
kgc00
suggested changes
Jan 29, 2022
Co-authored-by: kgc00 <kirby@expo.io>
kgc00
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Authentication is required for signing manifests in
expo start, otherwise you cannot use secure features in Expo Go. Since user info is used forexpo startmanifest middleware, authentication might as well be here as well.The API contents were copied over from
expo/eas-cliwhich were also copied fromexpo/expo-cli, I've opted to use the newer API since the older one is unmaintained.The newer API appears to implement a multitude of heavy packages which differ from what we used originally in expo-cli. Will need to take a pass at rewriting features using got to use node-fetch (
eas-cliuses both).Test Plan
eas-clitestsnexpo login,nexpo logout,nexpo register,nexpo whoamilocally to ensure everything works.Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).