Upgrade to react-native 0.67 #16038

Kudo · 2022-01-24T16:15:01Z

Why

try to bump react-native version for sdk 45

How

upgrade package.json version to react-native@0.67.2
apply changes from upgrade helper
since 0.67 upgrade to gradle 7 and remove maven plugin. ~~this pr also migrate packages to use maven-publish plugin~~ landed in separated pr [packages] replace maven plugin with maven-publish plugin #16080
[bare-expo][android] maven plugin from third-party: react-native-appearance. ~~consider it's archived and deprecated, how to deal with this.~~ since we are going to drop sdk 42, i've removed this dependency.
[bare-expo][android] maven plugin from third-party: react-native-shared-element. [fix] Fix Android build error on react-native 0.67 IjzerenHein/react-native-shared-element#90
[dev-launcher][android] having a DevLauncherDevSupportManager.kt for 0.67 and passing null to the new SurfaceDelegateFactory. simply to fix the build error first.
[dev-menu][android] it will crash from missing libjsc.so in hermes mode. ~~workaround to use jsc mode first~~. fix pr: [dev-menu] Fix crash when using hermes on android react-native 0.67 #16099

Test Plan

bare-expo launch

Checklist

Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
This diff will work correctly for expo build (eg: updated @expo/xdl).
This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

Krisztiaan · 2022-01-27T19:47:57Z

[bare-expo][android] maven plugin from third-party: react-native-appearance. consider it's archived and deprecated, how to deal with this.

Why is this necessary to keep, when react-native has it's own Appearance now?

Kudo · 2022-01-27T20:03:54Z

@Krisztiaan it's not necessary as we are going to deprecate expo sdk 42. i'll remove it later. thanks!

Krisztiaan · 2022-01-27T22:33:43Z

@Kudo cliPath seems broken with react-native. Omitting it by default, or using a relative path solves this issue.

react-native/react.gradle introduced a change to break it, released in 0.67.1

if (config.cliPath) {
    return "${projectDir}/${config.cliPath}"
}

Krisztiaan · 2022-01-27T22:41:30Z

I have created a PR on react-native to address this where it was broken.

Kudo · 2022-01-28T10:16:10Z

that's great. thanks @Krisztiaan!

…16099) # Why fix crash when `enableHermes: true` with dev-menu on react-native 0.67. i tested it from bare-expo. stacktrace: ``` FATAL EXCEPTION: main Process: dev.expo.payments, PID: 18344 java.lang.NoClassDefFoundError: com.facebook.react.jscexecutor.JSCExecutor at com.facebook.react.jscexecutor.JSCExecutor.loadLibrary(JSCExecutor.java:24) at com.facebook.react.ReactInstanceManagerBuilder.getDefaultJSExecutorFactory(ReactInstanceManagerBuilder.java:352) at com.facebook.react.ReactInstanceManagerBuilder.build(ReactInstanceManagerBuilder.java:319) at com.facebook.react.ReactNativeHost.createReactInstanceManager(ReactNativeHost.java:95) at expo.modules.devmenu.DevMenuHost.createReactInstanceManager(DevMenuHost.kt:41) at com.facebook.react.ReactNativeHost.getReactInstanceManager(ReactNativeHost.java:42) at expo.modules.devmenu.DevMenuManager.maybeInitDevMenuHost$lambda-8(DevMenuManager.kt:169) at expo.modules.devmenu.DevMenuManager.lambda$rZDvUiNHHHvkcRmdKO265huCv6U(Unknown Source:0) at expo.modules.devmenu.-$$Lambda$DevMenuManager$rZDvUiNHHHvkcRmdKO265huCv6U.run(Unknown Source:0) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:223) at android.app.ActivityThread.main(ActivityThread.java:7656) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947) Caused by: java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libjscexecutor.so SoSource 0: com.facebook.soloader.ApkSoSource[root = /data/data/dev.expo.payments/lib-main flags = 1] SoSource 1: com.facebook.soloader.DirectorySoSource[root = /data/app/~~ibMyBupkSRJXdt_c772rhw==/dev.expo.payments-ru7gzQ9g2MilqIhz24Lduw==/lib/arm64 flags = 0] SoSource 2: com.facebook.soloader.DirectorySoSource[root = /vendor/lib64 flags = 2] SoSource 3: com.facebook.soloader.DirectorySoSource[root = /system/lib64 flags = 2] Native lib dir: /data/app/~~ibMyBupkSRJXdt_c772rhw==/dev.expo.payments-ru7gzQ9g2MilqIhz24Lduw==/lib/arm64 ``` the first time to create a `ReactInstanceManager`, it successes. however, the second time to create a `ReactInstanceManager` for dev-menu, it crashes with `NoClassDefFoundError`. it's also uncaughtable [here](https://github.com/facebook/react-native/blob/20b9ed91c02a0cbf2f970bf51ccc4c278c63540c/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManagerBuilder.java#L348-L354) this is because the change landed in react-native 0.67: facebook/react-native#30749 according to jvm spec v2 2.17.5, ([maybe from this spec](https://docs.oracle.com/javase/specs/jvms/se6/html/Concepts.doc.html#24237)). the second time to load a failure class, the vm throws `NoClassDefFoundError`. [there's another reference in android art vm implementation](https://android.googlesource.com/platform/art/+/ec696e5d98ae4c503966f199bac341b50bfa1a5b/runtime/class_linker.cc#478) # How for dev-menu, we try to locate `libjsc.so` and create specific javascript executor. # Test Plan tested on my react-native 0.67 upgrade branch: #16038

Simek · 2022-01-29T09:15:18Z

Fixes #16040

For unknow for me reason I wasn't able to link the issue from the UI, so I need to leave a comment. 🤷‍♂️

hirbod · 2022-02-02T20:21:49Z

RN 0.67.2 is already out (+ fixing CVE-2021-0341)

Kudo · 2022-02-14T15:31:07Z

ci error from #16145, maybe @Simek could help to take a look when you get a chance. i am going to set this pr ready for review even facebook/react-native#32983 is not landed yet.

bbarthec

Looking dope 🚀
Superb work on upgrading the RN to the newest version 👏

brentvatne

looks like tests will pass after rebasing on top of #16300 so

…elper/?from=0.66.4&to=0.67.1

Kudo · 2022-02-17T01:43:45Z

just rebased and will merge after ci passing.

expo-bot · 2022-02-17T01:44:49Z

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries

Your changes should be noted in the changelog. Read Updating Changelogs guide and consider (it's optional) adding an appropriate entry to the following changelogs:

Generated by ExpoBot 🤖 against dda36b0

# Why try to bump react-native version for sdk 45 # How - [x] upgrade package.json version to `react-native@0.67.2` - [x] apply changes from [upgrade helper](https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.67.2) - [x] since 0.67 upgrade to gradle 7 and remove `maven` plugin. ~this pr also migrate packages to use `maven-publish` plugin~ landed in separated pr expo#16080 - [x] [bare-expo][android] maven plugin from third-party: `react-native-appearance`. ~consider it's archived and deprecated, how to deal with this.~ since we are going to drop sdk 42, i've removed this dependency. - [x] [bare-expo][android] maven plugin from third-party: `react-native-shared-element`. IjzerenHein/react-native-shared-element#90 - [x] [dev-launcher][android] having a `DevLauncherDevSupportManager.kt` for 0.67 and passing null to the new `SurfaceDelegateFactory`. simply to fix the build error first. - [x] [dev-menu][android] it will crash from missing libjsc.so in hermes mode. ~workaround to use jsc mode first~. fix pr: expo#16099 # Test Plan - bare-expo launch

expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 24, 2022

Kudo mentioned this pull request Jan 24, 2022

[fix] Fix Android build error on react-native 0.67 IjzerenHein/react-native-shared-element#90

Merged

Kudo mentioned this pull request Jan 27, 2022

[dev-menu] Fix crash when using hermes on android react-native 0.67 #16099

Merged

3 tasks

Kudo force-pushed the @kudo/rn067 branch from 1af36f1 to f7298ad Compare January 27, 2022 20:31

Kudo force-pushed the @kudo/rn067 branch from f7298ad to 656f565 Compare January 28, 2022 10:15

Kudo force-pushed the @kudo/rn067 branch from 656f565 to 3c0aa62 Compare January 28, 2022 14:46

danieldanielecki mentioned this pull request Feb 13, 2022

Fix issue with Gradle and Android simulator tamotam-com/tamotam-app#17

Closed

Kudo force-pushed the @kudo/rn067 branch from 3c0aa62 to 86aedc4 Compare February 14, 2022 07:39

Kudo requested review from lukmccall, tsapeta and brentvatne February 14, 2022 15:31

Kudo marked this pull request as ready for review February 14, 2022 15:31

Kudo requested a review from ide as a code owner February 14, 2022 15:31

Kudo removed the request for review from ide February 14, 2022 15:31

Simek mentioned this pull request Feb 14, 2022

[apps] cleanup and fixes after AV type changes #16300

Merged

3 tasks

bbarthec approved these changes Feb 15, 2022

View reviewed changes

linear bot mentioned this pull request Feb 15, 2022

[dev-launcher] Add support for RN 67 #16308

Closed

brentvatne approved these changes Feb 17, 2022

View reviewed changes

Kudo added 3 commits February 17, 2022 09:42

bump react-native package.json version to 0.67.1

acd2ab7

apply changes from https://react-native-community.github.io/upgrade-h…

e71b564

…elper/?from=0.66.4&to=0.67.1

[bare-expo] update podfile.lock

4b2a91f

Kudo added 6 commits February 17, 2022 09:42

[dev-launcher] fix android build error

59a2236

upgrade react-native-shared-element

78b0646

[bare-expo] remove react-native-appearance

d6ffe0d

workaround cliPath breaking change

869e389

upgrade to react-native 0.67.2

037f176

update podfile.lock

dda36b0

Kudo force-pushed the @kudo/rn067 branch from 86aedc4 to dda36b0 Compare February 17, 2022 01:43

Kudo merged commit f5787ad into main Feb 17, 2022

Kudo deleted the @kudo/rn067 branch February 17, 2022 16:55

Simek mentioned this pull request Feb 21, 2022

[templates] update locks after bumping RN in workspace #16397

Merged

3 tasks

lukmccall mentioned this pull request Feb 28, 2022

React Native 0.67.3 expo-dev-launcher Android Task :expo-dev-launcher:compileDebugKotlin FAILED #16465

Closed

robinheinze mentioned this pull request Mar 4, 2022

react-native/cli.js not found on new project infinitered/ignite#1907

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to react-native 0.67 #16038

Upgrade to react-native 0.67 #16038

Kudo commented Jan 24, 2022 •

edited

Krisztiaan commented Jan 27, 2022

Kudo commented Jan 27, 2022

Krisztiaan commented Jan 27, 2022 •

edited

Krisztiaan commented Jan 27, 2022

Kudo commented Jan 28, 2022

Simek commented Jan 29, 2022 •

edited

hirbod commented Feb 2, 2022

Kudo commented Feb 14, 2022

bbarthec left a comment

brentvatne left a comment

Kudo commented Feb 17, 2022

expo-bot commented Feb 17, 2022

Upgrade to react-native 0.67 #16038

Upgrade to react-native 0.67 #16038

Conversation

Kudo commented Jan 24, 2022 • edited

Why

How

Test Plan

Checklist

Krisztiaan commented Jan 27, 2022

Kudo commented Jan 27, 2022

Krisztiaan commented Jan 27, 2022 • edited

Krisztiaan commented Jan 27, 2022

Kudo commented Jan 28, 2022

Simek commented Jan 29, 2022 • edited

hirbod commented Feb 2, 2022

Kudo commented Feb 14, 2022

bbarthec left a comment

Choose a reason for hiding this comment

brentvatne left a comment

Choose a reason for hiding this comment

Kudo commented Feb 17, 2022

expo-bot commented Feb 17, 2022

Kudo commented Jan 24, 2022 •

edited

Krisztiaan commented Jan 27, 2022 •

edited

Simek commented Jan 29, 2022 •

edited