[apps] Enforce 'util' version to fix errors on import #15698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
the js import error:
Error: Requiring module "../../packages/expo-notifications/build/index.js", which threw an exception: TypeError: Cannot read property 'isPromise' of undefined, js engine: hermes
will show in red box and break detox testing.the dependency:
updateDevicePushTokenAsync.ts
->@ide/backoff
->require('assert')
->require('util')
andutil.types.isPromise
.util.types.isPromise
is added after util@0.12, but the oldutil
be hoisted to workspace:in theory, from
assert
to importutil
, it should import the nested one. so it should not be a big problem even the oldutil
be hoisted to workspace.however, in #15621, the new
@expo/metro-config@~0.3.7
, we addednodeModulesPaths
to metro config. the old metro resolver will prependnodeModulesPaths
before all resolution path. this will makeassert
to import the oldutil
from workspace. this issue is fixed in the latest metro version: facebook/metro#738.How
have a workaround to force
util@~0.12.4
for all dependenciesTest Plan
test-suite ci green
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).