[expo-av][android] fix video width same as video height

[mtroskot]

Why

On Android for some videos the width is the same as the video height. This PR fixes that issue.

#12839

How

Using pixelWidthHeightRatio as described in google/ExoPlayer#3690

Test Plan

Tested on emulator with reproducible example https://snack.expo.dev/@trokiize/android-video-size-wrong.

[expo-bot]

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries

Your changes should be noted in the changelog. Read Updating Changelogs guide and consider (it's optional) adding an appropriate entry to the following changelogs:

• packages/expo-av/CHANGELOG.md

---

Generated by ExpoBot 🤖 against 9b48bca

[jeremyspritelyco]

why does this PR still open? does the issue fixed?

[jeremyspritelyco]

thanks for this PR. I am using this changes with patch package and it fixed my issue, related to #12839

[bbarthec]

As long as this PR does the job I'm ok with that, but it looks fishy that origianl height is not reported correctly and it's needed to be calculated from the pixelWidthHeightRatio and width.
cc @lukmccall, @tsapeta
The PR itself lacks proper CHANGELOG entry.

[lukmccall]

It doesn't seem right. Can you provide more context about your solution?

[mtroskot]

Doesn't the linked ExoPlayer github issue and the reproducible demo give enough context ?

[lukmccall]

Doesn't the linked ExoPlayer github issue and the reproducible demo give enough context?

Ok, you convinced me that is enough information. It seems very weird that we have to calculate the video width. I'll merge that, but please add a changelog entry to https://github.com/expo/expo/blob/main/packages/expo-av/CHANGELOG.md

[cgav]

@mtroskot Any chance you could add the changelog entry? Would be nice to finally have that issue resolved 🙂

[lukmccall]

That issue should be fixed by #19332. We bumped the ExoPlayer. The current version should return the correct video size.

[cgav]

@lukmccall It still seems to be broken in Expo47. I have tweaked the snack from @mtroskot and upgraded the npm modules to the latest versions. As you can see it shows a popup with the same width and height.

Snack: https://snack.expo.dev/@cgavrilete/android-video-size-wrong

[lukmccall]

According to the https://github.com/google/ExoPlayer/blob/release-v2/RELEASENOTES.md#2140-2021-05-13 changelog, the fix which was pointed out in the description should be applied to the ExoPlayer codebase. It may not be enough, but it also means that this PR won't fix that either. I'll take a closer look later to check if that's true.