Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] Add .editorconfig for Kotlin #13829

Closed
wants to merge 2 commits into from
Closed

[android] Add .editorconfig for Kotlin #13829

wants to merge 2 commits into from

Conversation

M1ST4KE
Copy link
Contributor

@M1ST4KE M1ST4KE commented Jul 29, 2021 •
edited

Why

  • For bare-expo Android Studio lint settings were different than ktlint settings.
  • Expo-go didn't have any Android Studio lint settings.
  • Kotlin lint settings were messy.

How

  • Added .editorconfig file and symlinks to it in expo-go and bare-expo android directories.
  • Set ktlint to take properties from .editorconfig file.
  • Added suggested editorconfig plugin for VS Code.

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jul 29, 2021
@M1ST4KE M1ST4KE changed the title Add and .editorconfig Add .editorconfig for Kotlin Jul 29, 2021
@M1ST4KE
Copy link
Contributor Author

M1ST4KE commented Jul 29, 2021 •
edited

It would be perfect if ktlint would take .editorconfig settings, but it doesn't support multi modules projects out of the box and this is the reason why we use spotless. Currently Spotless doesn't support .editorconfig files #142, I have some ideas how we can solve the issue:

  • Get rid of spotless and provide a custom Gradle plugin that will add ktlint to each module
  • Implement feature mentioned in the issue above
  • Wait till the feature will be implemented 😎

@M1ST4KE M1ST4KE changed the title Add .editorconfig for Kotlin [android] Add .editorconfig for Kotlin Jul 29, 2021
@M1ST4KE M1ST4KE marked this pull request as ready for review July 29, 2021 13:37
@M1ST4KE M1ST4KE closed this by deleting the head repository Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@M1ST4KE @expo-bot @kowczarz