Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android] Fix ktlint settings #13814

Merged
merged 2 commits into from
Jul 29, 2021
Merged

[android] Fix ktlint settings #13814

merged 2 commits into from
Jul 29, 2021

Conversation

M1ST4KE
Copy link
Contributor

@M1ST4KE M1ST4KE commented Jul 28, 2021 •
edited

Why

  • CONTINUATION_INDENT_SIZE in ktlint settings didn't work
  • In Java, all types of intents were set to 2 spaces, so I wanted to keep these settings in Kotlin.

How

  • Removed not-working rules.
  • Added some more rules which are already satisfied.

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jul 28, 2021
bbarthec
bbarthec reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@bbarthec bbarthec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I wish we had editorconfig for each filetype we're having the repository 😅
What about removed line: "disabled_rules" : "no-wildcard-imports,import-ordering"? These rules are going to be required again, am I right? 🤔

@M1ST4KE M1ST4KE changed the title [android] Clean up kotlin lint settings [android] Fix ktlint settings Jul 29, 2021
@M1ST4KE
Copy link
Contributor Author

M1ST4KE commented Jul 29, 2021

Unfortunately currently spotless doesn't support .editorconfig files #142. That's why I removed the file from this PR. Now it's only about fixing the lint config and I will provide another one, where I will add .editorconfig and provide how we can work around the issue mentioned above.

@M1ST4KE M1ST4KE marked this pull request as ready for review July 29, 2021 12:40
@bbarthec bbarthec merged commit 22ff1ca into expo:master Jul 29, 2021
FelipeACP pushed a commit to FelipeACP/expo that referenced this pull request Sep 18, 2021
@kowczarz
[android] Fix ktlint settings (expo#13814)
ec36ec7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbarthec bbarthec bbarthec approved these changes

@brentvatne brentvatne Awaiting requested review from brentvatne

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@M1ST4KE @bbarthec @expo-bot @kowczarz