-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[core] fix androidTest build issues (#19469)
# Why a couple of issues i find when investigating the jsc problem in #19411 # How - from #19372 and #19447, i noticed the androidTest running from bare-expo is crashing. the crash is libc++_shared.so not found. when i try to use `pickFirsts` to fix that, there's another `__emutls_get_address` symbol not found crashing issue. that happens because i build ReactAndroid by ndk r24, but expo-modules-core by ndk r21 (the default side-by-side ndk version in the current AGP). so the first addressing issue is to align the ndk version with the root project. - support hermes building on react-native 0.70 without building from source. close ENG-6598 - use static c++ runtime for androidTest - this is the most complicated stuff. when running `et android-native-unit-tests -t instrumented`, it executes multiple androidTest commands together, e.g. `./gradlew :expo-modules-core:connectedAndroidTest :expo-eas-client:connectedAndroidTest`. if we use `pickFirsts` strategy, it will have multiple libc++_shared.so error when building expo-eas-client androidTest, one from e-m-c, and the other from ReactAndroid. so maybe the easy solution is to have static c++ runtime for androidTest. # Test Plan after these changes, the androidTest will fail both on jsc and hermes. to test everything works, i have to comment out other broken tests: `JSIFunctionTest.coded_error_should_be_converted` and `JSIFunctionTest.arbitrary_error_should_be_converted` - ✅ [bare-expo] `./gradlew :expo-modules-core:connectedAndroidTest :expo-eas-client:connectedAndroidTest` - ✅ [bare-expo] `./gradlew :expo-modules-core:connectedAndroidTest` - ✅ [bare-expo] `./gradlew :expo-eas-client:connectedAndroidTest` - ✅ [android expo go] `./gradlew :expo-modules-core:connectedAndroidTest :expo-eas-client:connectedAndroidTest` - ✅ [android expo go] `./gradlew :expo-modules-core:connectedAndroidTest` - ✅ [android expo go] `./gradlew :expo-eas-client:connectedAndroidTest`
- Loading branch information
Showing
4 changed files
with
56 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters