Upgrade to latest three.js version #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fulfills ENG-6086.
How
three@0.145.0
, updated other packagesGeometry
, which was deprecated atthree@0.125.0
. Seems to only affectutils.computeMeshNormals
.mesh.child.geometry
seems to now be aBufferGeometry
, but I didn't have a good way to test this function.Test Plan
Unresolved stuff
Cannot use import statement outside a module
when reading three's jsm loaders. Seemed like something that could be fixed withtransformIgnorePatterns
, but it made no difference, so could use advice there.Checklist
expo prebuild
& EAS Build (eg: updated a module plugin).