Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest three.js version #275

Merged
merged 5 commits into from
Oct 28, 2022

Conversation

keith-kurak
Copy link
Contributor

@keith-kurak keith-kurak commented Oct 26, 2022

Why

Fulfills ENG-6086.

How

  • Update peer dep and example to three@0.145.0, updated other packages
  • Remove refs to Geometry, which was deprecated at three@0.125.0. Seems to only affect utils.computeMeshNormals. mesh.child.geometry seems to now be a BufferGeometry, but I didn't have a good way to test this function.
  • Fix some TS errors

Test Plan

  • Tested the example, looked good

Unresolved stuff

  • Unit tests were bombing before it even got to the test file. I got it to at least fail the tests themselves with Cannot use import statement outside a module when reading three's jsm loaders. Seemed like something that could be fixed with transformIgnorePatterns, but it made no difference, so could use advice there.
  • I wanted to test loading an obj in the example. I think it'd be nice to include this in the example itself, as there seems to be some questions about that in issues. However, I couldn't find example .obj/ .mtl files that I knew for sure would be appropriately licensed to include in here. At the moment, I left my known good code in the example, but commented out, as it would fail without the actual assets. If anyone has some assets I could include, that'd be great.
  • Apparently I can't get linting running, either :-/

Checklist

@linear
Copy link

linear bot commented Oct 26, 2022

ENG-6086 Upgrade expo-three

Resolve issues found while updating examples for SDK 46: expo/examples#385

This package may just need more recent peerDependencies (only worked after upgrading to a more recent version of three than 0.127.0.

@jaymes-bearden
Copy link

Any chance we could get this merged in and available for SDK46+?

@wkozyra95
Copy link
Contributor

@keith-kurak You can use files from three.js examples or if you don't want to embed them in the app you can try specifying them via URL to three.js github

e.g. https://github.com/mrdoob/three.js/tree/dev/examples/models/obj

@keith-kurak keith-kurak merged commit b4e43f6 into master Oct 28, 2022
@keith-kurak keith-kurak deleted the keith/eng-6086-upgrade-expo-three branch October 28, 2022 14:58
@jaymes-bearden
Copy link

Thank you for this merge! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants