Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

feature(create-expo-app): add --example flag to initialize from example #4644

Merged
merged 4 commits into from Feb 7, 2023

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Feb 6, 2023

Why

Fixes ENG-7493

How

Warning
I ran into the "premature close" error when testing this: isaacs/node-tar#321. I upgraded tar@6.1.11 to tar@6.1.13 to avoid this.

Test Plan

See tests and help info:

$ yarn create expo-app --help

# Show list of examples to create from
$ yarn create expo-app --example
# Or create a new example by name
$ yarn create expo-app --example with-router

@linear
Copy link

linear bot commented Feb 6, 2023

ENG-7493 Add support for expo/examples to create-expo-app

We currently only support the legacy templates because they're versioned but this causes us to need create-react-native-app for things like expo-router. We should add -e | --example to create-expo-app. This would differ from templates which are correctly versioned and accept sdk versions.

Alternatively we could add versioning to expo examples by cutting release branches but that seems like a fair amount of work for now.

@byCedric byCedric force-pushed the @bycedric/create-expo-app/add-examples branch from 8f2824d to 1973811 Compare February 7, 2023 15:30
@byCedric byCedric merged commit a8745a2 into main Feb 7, 2023
@byCedric byCedric deleted the @bycedric/create-expo-app/add-examples branch February 7, 2023 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants