Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Trying to upgrade this where we use it, but it is resulting in conflicting typescript types I believe. https://github.com/expo/universe/pull/11100
https://nvd.nist.gov/vuln/detail/CVE-2016-20018 says Knex has a SQL injection that can cause the WHERE clause to be ignored. It's unclear how this is triggered, and due to the usage pattern within entity it is doubtful that it affects us, but still good to stay upgraded.
How
Upgrade to Knex 2.3.0. This is a major semver upgrade. However, the breaking change in 2.3.0 was adding back support for sqlite3. That does not affect us. I read through the changelog and saw no other changes that would affect us, though there is better support for JSONB and Postgres now: knex/knex#5201
Test Plan
Run all tests.