Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing pydantic v1.10.0a1 #744

Closed

Conversation

samuelcolvin
Copy link

see explosion/spaCy#11371

TO NOT MERGE

This is pull request is just to test pydantic v1.10, see pydantic/pydantic#4359

@adrianeboyd
Copy link
Contributor

You'll also want to update setup.cfg.

@samuelcolvin
Copy link
Author

thanks, this has already caught pydantic/pydantic#4424.

I'll make a new patch release, then update the PR.

@samuelcolvin
Copy link
Author

Just a quick warning, something, I think this line is installing an old version of typing-extensions and upsetting quite a few packages.

From the test log:

pydantic 1.10.0a2 requires typing-extensions>=4.1.0, but you have typing-extensions 3.7.4.3 which is incompatible.
mypy 0.961 requires typing-extensions>=3.10, but you have typing-extensions 3.7.4.3 which is incompatible.
black 22.6.0 requires typing-extensions>=3.10.0.0; python_version < "3.10", but you have typing-extensions 3.7.4.3 which is incompatible.

@samuelcolvin
Copy link
Author

Pydantic v1.10 drops support for python 3.6.

@adrianeboyd
Copy link
Contributor

We have not made any official decisions about dropping python 3.6 compatibility. There aren't many advantages for our current codebase in dropping python 3.6, I think there will be more for dropping python 3.7.

@samuelcolvin
Copy link
Author

That's fine, just letting you know.

Removing 3.6 allowed some significant improvements in pydantic's code base.

@samuelcolvin
Copy link
Author

Great, this is passing except for 3.6 which is expected.

@svlandeg svlandeg added the third-party Related to third-party packages label Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
third-party Related to third-party packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants