New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build matrix and job run conditions #38
Conversation
# Conflicts: # spacy_llm/compat.py
python -m pip uninstall dotenv | ||
python -m pip uninstall python-dotenv | ||
python -m pip install python-dotenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't great, but I don't know how to get around this - there seems to be a version of dotenv
installed already that doesn't play nice with the dependency that's expected.
# Conflicts: # spacy_llm/tests/tasks/test_ner.py
I think it's probably more important to the basics merged here than deal with the warning, so maybe for now remove |
Yeah, I'm trying one last thing. If that doesn't work out, I'll drop |
Ready to be reviewed. Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - agreed with prioritizing getting this merged first, and working more on the warning filters later. Would appreciate a final review by Adriane as well 🙏
[update: I'll go ahead and merge this for now so we can continue to build on it]
And thanks again to @adrianeboyd for your help with this! |
Description
main
.Types of change
Expanding test suite.
Checklist