Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typing errors, autocomplete on registry functions #30

Merged
merged 22 commits into from
May 9, 2023
Merged

Fix some typing errors, autocomplete on registry functions #30

merged 22 commits into from
May 9, 2023

Conversation

kabirkhan
Copy link
Contributor

@kabirkhan kabirkhan commented May 8, 2023 •
edited by rmitsch

Description

Fixes typing errors and inconsistencies.

  • Make a custom registry so typing/autocomplete works
  • Various type fixes for both mypy and pyright
  • Pyright config added

Types of change

Enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@kabirkhan kabirkhan changed the title Fix some typing errors, autocomplete on registry functions #29 Fix some typing errors, autocomplete on registry functions May 8, 2023
@kabirkhan kabirkhan mentioned this pull request May 8, 2023
Closed
3 tasks
@kabirkhan kabirkhan marked this pull request as ready for review May 8, 2023 22:12
svlandeg
svlandeg reviewed May 8, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I only had one question around the minichain type edits.

@svlandeg svlandeg added the refactoring Refactoring of existing code label May 9, 2023
rmitsch
rmitsch reviewed May 9, 2023
View reviewed changes
spacy_llm/backends/langchain.py Outdated Show resolved Hide resolved
spacy_llm/backends/minichain.py Outdated Show resolved Hide resolved
spacy_llm/pipeline/llm.py Show resolved Hide resolved
spacy_llm/pipeline/llm.py Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@svlandeg @rmitsch
update type
53265c0 
Co-authored-by: Raphael Mitsch <r.mitsch@outlook.com>
@rmitsch rmitsch assigned rmitsch and unassigned rmitsch May 9, 2023
svlandeg
svlandeg approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@svlandeg svlandeg merged commit 100f850 into main May 9, 2023
2 checks passed
@svlandeg svlandeg deleted the kab/types branch May 9, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianeboyd adrianeboyd adrianeboyd left review comments

@rmitsch rmitsch rmitsch left review comments

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
refactoring Refactoring of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kabirkhan @adrianeboyd @rmitsch @svlandeg