Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use max(uint64) for OOV lexeme rank #5303

Merged
merged 6 commits into from
Apr 15, 2020
Merged

Use max(uint64) for OOV lexeme rank #5303

merged 6 commits into from
Apr 15, 2020

Commits on Apr 14, 2020

  1. Use max(uint64) for OOV lexeme rank

    @adrianeboyd
    adrianeboyd committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    2fd14eb View commit details
    Browse the repository at this point in the history

  2. Add test for default OOV rank

    @adrianeboyd
    adrianeboyd committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    8ac842d View commit details
    Browse the repository at this point in the history

  3. Revert back to thinc==7.4.0 

    Requiring the updated version of thinc was unnecessary.
    @adrianeboyd
    adrianeboyd committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    422eb59 View commit details
    Browse the repository at this point in the history

  4. Define OOV_RANK in one place 

    Define OOV_RANK in one place in `util`.
    @adrianeboyd
    adrianeboyd committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    a66e83e View commit details
    Browse the repository at this point in the history

  5. Fix formatting [ci skip]

    @adrianeboyd
    adrianeboyd committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    db7ba5f View commit details
    Browse the repository at this point in the history

  6. Switch to external definitions of max(uint64) 

    Switch to external defintions of max(uint64) and confirm that they are
equal.
    @adrianeboyd
    adrianeboyd committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    afe5592 View commit details
    Browse the repository at this point in the history