-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matcher support for Span as well as Doc #5113
Conversation
Hi @paoloq, thanks for your pull request! 👍 It looks like you haven't filled in the spaCy Contributor Agreement (SCA) yet. The agreement ensures that we can use your contribution across the project. Once you've filled in the template, put it in the If you've already included the Contributor Agreement in your pull request above, you can ignore this message. |
Hi @paoloq : apologies for the late follow-up. Could you merge the latest version of Let me know if you need help merging! |
Thanks a lot for your contribution! It's now merged, and will be included in the next release of spaCy, probably 2.3 (or otherwise 3.0) 👍 |
Description
Matcher support for searching on a Span, as well as a Doc. Fixes #5056
Missing of an appropriate error message at line 228 in
matcher.pxy
Types of change
Enhancement/feature for the Matcher.
Checklist