Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python 3.11.2 Upgrade] Updated Dockerfile and Requirements #112

Merged
merged 4 commits into from
Apr 7, 2023

Conversation

BethanyG
Copy link
Member

@BethanyG BethanyG commented Apr 2, 2023

This upgrade should happen at the same time for the Test Runner, Analyzer, & Representer
After these three are merged, the updates to the track CI and Content should be merged.

  • Updated Dockerfile to use python:3.11.2-slim
  • Updated Requirements.txt
    • pytest~=7.2.2 🎉
    • pytest-subtests~=0.10.0
  • Changed pytest.ini file (color codes were breaking the golden tests)
    • addopts = --color=no
    • console_output_style =classic
  • Changed the runner __init__.py file to strip new subtest fail inserts where possible.
  • Regenerated 6 Golden Test results.json, due to changes in Python 3.11 output.

…ed some golden files to match new 3.11 output.
@BethanyG
Copy link
Member Author

BethanyG commented Apr 2, 2023

@ErikSchierboom & @iHiD - tagging you both, as this is an upgrade to a new version of Python. Given the upgrades done by the R track and the Go track, this one may be cursed as well. 😱 🤞🏽 that we are lucky here, and slide into production without issue. 😁

All tests against exercises and golden files do pass, and I have had zero issues on my machine when testing. As promised by the Python Dev team, this release does indeed feel speedy.

Changes to the track CI were .. bumpy ... but are resolved. Documentation updates are still pending, and should be done by the EOD/Monday latest.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikSchierboom ErikSchierboom merged commit 7a5d952 into exercism:main Apr 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants