Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new Exercise] lens-person #2400

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

sarava338
Copy link

created lens-person/ in exercises/practice
added .meta/config.json
added Instruction and Introduction in .docs/
added lens-person.js, lens.person.spec.js and .meta/proof.ci.js files
copied babel.config.js, LICENCE, .npmrc, .gitignore, .eslintrc
created src/ for util classes like Person.js, Name.js, Born.js, Address.js, Lens.js

I have checked test cases. But I am still not sure if tests are running fine, Please help me by checking the test cases especially test cases for immutability

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@sarava338 sarava338 changed the title Closes #912 [new Exercise] lens-person [new Exercise] lens-person Feb 27, 2024
@sarava338
Copy link
Author

Hi Reviewers,

Need review.

@Cool-Katt
Copy link
Contributor

@sarava338
Is this still being worked on?
As it is now, it doesn't pass the CI checks.

@sarava338
Copy link
Author

sarava338 commented Mar 26, 2024

@sarava338

Hi @Cool-Katt

Is this still being worked on?

I could not able to solve this CI checks. And I have manually created all the files. But, I saw your commit msg in other new exercises that's being added to exercism, it's generated by configlets. I don't know how to do that as of now.

As it is now, it doesn't pass the CI checks.

if you don't mind, Could you please take over this exercise. I am yet to learn more to create a new exercise on exercism...

@Cool-Katt
Copy link
Contributor

@sarava338

Okay then, with your permission, I'll file another PR.

About configlet, and other tooling we use, you can read more on the docs page. It may be useful to acquaint yourself with the docs and proper procedures for adding an exercise to the track.

@sarava338
Copy link
Author

@sarava338

Okay then, with your permission, I'll file another PR.

About configlet, and other tooling we use, you can read more on the docs page. It may be useful to acquaint yourself with the docs and proper procedures for adding an exercise to the track.

@Cool-Katt Thanks Mate 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants