-
-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new Exercise] lens-person #2400
base: main
Are you sure you want to change the base?
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
Hi Reviewers, Need review. |
@sarava338 |
Hi @Cool-Katt
I could not able to solve this CI checks. And I have manually created all the files. But, I saw your commit msg in other new exercises that's being added to exercism, it's generated by configlets. I don't know how to do that as of now.
if you don't mind, Could you please take over this exercise. I am yet to learn more to create a new exercise on exercism... |
Okay then, with your permission, I'll file another PR. About |
@Cool-Katt Thanks Mate 🙂 |
created lens-person/ in exercises/practice
added .meta/config.json
added Instruction and Introduction in .docs/
added lens-person.js, lens.person.spec.js and .meta/proof.ci.js files
copied babel.config.js, LICENCE, .npmrc, .gitignore, .eslintrc
created src/ for util classes like Person.js, Name.js, Born.js, Address.js, Lens.js
I have checked test cases. But I am still not sure if tests are running fine, Please help me by checking the test cases especially test cases for immutability